Make the value arg optional for set command #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praneetloke
commented
Sep 18, 2024
| @@ -16,6 +16,8 @@ run: | | |||
| esc env get default/test | |||
| esc env set default/test password true --secret | |||
| esc env get default/test | |||
| echo 'mysecret' | esc env set default/test password --secret | |||
There was a problem hiding this comment.
As mentioned in the PR description, I can't get this to work. It's as if echo 'mysecret' evaluates to an empty string because that's what the value of esc env set ... ends up getting. However, building a local version of the CLI and executing the same thing works as expected, so I am not sure what is going on with the test runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340.
This PR uses the same code as Pulumi CLI to prompt the user for a value if no value is specificed when in interactive mode.
Although I updated the test, I couldn't get it to pass because the pipe command seems to not run correctly? I couldn't quite figure out what is going on and hope that one of you knows how to get the test to pass. FWIW, I built a local version of the CLI and have confirmed it to work with these changes, i.e. I can run
echo 'secret' | esc env set <workspace> <path> --secret(as well as without--secret.)