Add anonymous open environment routes #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyeh
force-pushed
the
syeh/add-anonymous-open-env
branch
from
431352f to
9f1ce7e
Compare
seanyeh
added
the
impact/no-changelog-required
cmd/esc/cli/client/client.go
Outdated
| @@ -677,6 +685,16 @@ func (pc *client) GetOpenEnvironmentWithProject(ctx context.Context, orgName, pr | |||
| return &resp, nil | |||
| } | |||
|
|
|||
| func (pc *client) GetAnonymousOpenEnvironment(ctx context.Context, orgName, openSessionID string) (*esc.Environment, error) { | |||
| var resp esc.Environment | |||
| path := fmt.Sprintf("/api/esc/environments/%v/yaml/open/%v", orgName, openSessionID) | |||
There was a problem hiding this comment.
Should this include project in the URL? As far as I understand, envName and project are not used, but eventually we will remove routes without project, right?
Also, nit - ideally should be more specific and use %s for strings, generic is always more bug-prone
There was a problem hiding this comment.
we will remove preview routes but this is a GA route. we decided that we don't need to include projects in this route for anonymous envs.
cmd/esc/cli/client/client.go
Outdated
| } | ||
|
|
||
| var resp esc.Value | ||
| path := fmt.Sprintf("/api/esc/environments/%v/yaml/open/%v", orgName, openSessionID) |
seanyeh
force-pushed
the
syeh/add-anonymous-open-env
branch
from
9f1ce7e to
9f2fd43
Compare
IaroslavTitov
approved these changes
Sep 6, 2024
seanyeh
added a commit
that referenced
this pull request
Sep 10, 2024
seanyeh
added a commit
that referenced
this pull request
Sep 10, 2024
seanyeh
added a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods for the anonymous open env routes so that the Pulumi CLI can use them