eval: improve unknown/secret for complex literals #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
force-pushed
the
komal/unknowns
branch
from
fb74ca5 to
5128725
Compare
komalali
commented
Nov 6, 2023
komalali
added
the
impact/no-changelog-required
komalali
force-pushed
the
komal/unknowns
branch
from
0ea9b72 to
129b885
Compare
komalali
force-pushed
the
komal/unknowns
branch
from
d7843c2 to
c9d5560
Compare
komalali
force-pushed
the
komal/preview-tests-redux
branch
2 times, most recently
from
1a1ec0f to
7f4a07c
Compare
komalali
force-pushed
the
komal/unknowns
branch
from
c9d5560 to
896ed1f
Compare
pgavlin
requested changes
Nov 7, 2023
Do not treat object and array literals that include unknown or secret
elements as unknown or secret themselves. Instead, leave it up to the
consumer of the literal to handle unknownness and secretness
appropriately (i.e. by combining the unknownness and secretness of each
leaf value the consumer observes).
For example, the following object definition no is no longer unknown
during check or secret during eval:
```yaml
foo:
bar: 42
baz:
fn::secret:
ciphertext: AjIAEJFDIe==
```
Instead, it is partially-known during check:
```yaml
foo:
bar: 42
baz: [unknown]
```
And partially-secret during eval:
```yaml
foo:
bar: 42
baz: [secret]
```
But when passed to `fn::toJSON`, the result of the call would be unknown
in check or secret in eval b/c of the nested unknown/secret.
Fixes #164.
Fixes pulumi/pulumi-service#16162.
pgavlin
force-pushed
the
komal/unknowns
branch
from
e37f50b to
8449b6f
Compare
pgavlin
changed the title
pgavlin
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not treat object and array literals that include unknown or secret
elements as unknown or secret themselves. Instead, leave it up to the
consumer of the literal to handle unknownness and secretness
appropriately (i.e. by combining the unknownness and secretness of each
leaf value the consumer observes).
For example, the following object definition no is no longer unknown
during check or secret during eval:
Instead, it is partially-known during check:
And partially-secret during eval:
But when passed to
fn::toJSON, the result of the call would be unknownin check or secret in eval b/c of the nested unknown/secret.
Fixes #164.
Fixes https://github.com/pulumi/pulumi-service/issues/16162.