Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax: add tests, s/list/array #124

Merged
merged 1 commit into from
Oct 18, 2023
Merged

syntax: add tests, s/list/array #124

merged 1 commit into from
Oct 18, 2023

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Oct 18, 2023

  • Add tests for the syntax package
  • Replace the term 'list' with 'array' in most occurrences

@pgavlin pgavlin added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Oct 18, 2023
@pgavlin pgavlin force-pushed the pgavlin/syntax-test branch from 48315a1 to bb4da74 Compare October 18, 2023 02:00
@pgavlin pgavlin enabled auto-merge (squash) October 18, 2023 14:31
lblackstone
lblackstone requested changes Oct 18, 2023
View reviewed changes
eval/eval.go Outdated Show resolved Hide resolved
syntax/encoding/node_test.go Show resolved Hide resolved
syntax/encoding/object_test.go Show resolved Hide resolved
syntax/encoding/object_test.go Show resolved Hide resolved
syntax/encoding/testdata/yaml/basic/doc.yaml Show resolved Hide resolved
syntax/encoding/yaml_test.go Show resolved Hide resolved
@pgavlin pgavlin force-pushed the pgavlin/syntax-test branch from bff7abd to 68c1ab1 Compare October 18, 2023 18:50
@pgavlin
syntax: add tests, s/list/array
593dcae 
- Add tests for the syntax package
- Replace the term 'list' with 'array' in most occurrences
@pgavlin pgavlin force-pushed the pgavlin/syntax-test branch from 68c1ab1 to 593dcae Compare October 18, 2023 18:50
@pgavlin pgavlin requested a review from lblackstone October 18, 2023 18:50
@pgavlin pgavlin merged commit d6d0769 into main Oct 18, 2023
@pgavlin pgavlin deleted the pgavlin/syntax-test branch October 18, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

@cleverguy25 cleverguy25 Awaiting requested review from cleverguy25

@komalali komalali Awaiting requested review from komalali

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgavlin @lblackstone