Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting account functionality for TS SDK #86

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Porting account functionality for TS SDK #86

merged 2 commits into from
Mar 21, 2025

Conversation

IaroslavTitov
Copy link
Contributor

@IaroslavTitov IaroslavTitov commented Mar 20, 2025

Summary

Testing

  • Same test suite as the Python version (asserts are slightly different due to the difference of how Configuration works between TS and Py)
  • Moved the test configuration files up, to share between all sdks
  • Manually tested against prod and review stack

@IaroslavTitov IaroslavTitov marked this pull request as ready for review March 21, 2025 15:32
@IaroslavTitov IaroslavTitov merged commit 9f154bc into main Mar 21, 2025
8 checks passed
sdk/typescript/test/**/* linguist-generated=false
sdk/typescript/* linguist-generated=false
sdk/test/**/* linguist-generated=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line isn't necessary since everything is false by default. the only reason we specify the others above as false is because of the wildcard for sdk/typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logic in typescript SDK to use ESC accounts
3 participants