🚧 Provide a TabBase and TabManagerBase implementation#61
Draft
trickypr wants to merge 4 commits intoartifact-based-browserfrom
Draft
🚧 Provide a TabBase and TabManagerBase implementation#61trickypr wants to merge 4 commits intoartifact-based-browserfrom
trickypr wants to merge 4 commits intoartifact-based-browserfrom
Conversation
This was referenced Apr 26, 2024
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
trickypr
force-pushed
the
04-21-_implement_browser_action_manifest_key_backend
branch
from
7c857ea to
401befb
Compare
4 tasks
Base automatically changed from
04-21-_implement_browser_action_manifest_key_backend
to
artifact-based-browser
April 26, 2024 05:19
trickypr
force-pushed
the
04-25-_provide_a_tabbase_and_tabmanagerbase_implementation
branch
from
a4615bb to
3e1a9b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mozilla provides shared code for implementing tab apis that I was avoiding using. However, because they expect it to exist, I have moved over to using it and all the problems that will cause. Here is the main changes:
TabandTabManagerextendingTabBaseandTabManagerBaseext-browserActionsandext-tabsto use the new apis