Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps Pulsar to the newest Electron stable version as of today.
Also, as of today, there are some breaking changes (for the absolute surprise of no one) for Electron, and some are still not addressed, for example:
Nan doesn't support Node 23
So I worked-around by making Nan depend on a specific PR, and unfortunately, I also had to force
node-addon-api
to be a specific version too. Surprisingly, it seems things work out well on my very limited tests.I'll merge back to my own local version, and test it over the week and update this PR with the results, if things are stable, etc.