Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electron to 34.0.1 #1202

Open
wants to merge 1 commit into
base: updated-latest-electron
Choose a base branch
from

Conversation

mauricioszabo
Copy link
Contributor

This bumps Pulsar to the newest Electron stable version as of today.

Also, as of today, there are some breaking changes (for the absolute surprise of no one) for Electron, and some are still not addressed, for example:

Nan doesn't support Node 23

So I worked-around by making Nan depend on a specific PR, and unfortunately, I also had to force node-addon-api to be a specific version too. Surprisingly, it seems things work out well on my very limited tests.

I'll merge back to my own local version, and test it over the week and update this PR with the results, if things are stable, etc.

@savetheclocktower
Copy link
Contributor

I'd like to hold off on this, if it's OK, for a couple of reasons:

  • upgrading this far would make it so that @DeeDeeG can no longer run PulsarNext (they're on an older macOS), so it would really neutralize them as a potential contributor;
  • if the nan situation is truly that bleeding-edge, it might be good to wait until all that gets worked out.

I also could've sworn that there were at least one or two of our packages still using (context-aware) nan that hadn't yet been migrated over to N-API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants