Add repository find mechanism #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-psb
force-pushed
the
add-fetch-functionality
branch
from
abcdddd to
747b324
Compare
pedro-psb
force-pushed
the
add-fetch-functionality
branch
3 times, most recently
from
874c2eb to
8838f05
Compare
mdellweg
reviewed
Apr 29, 2025
src/pulp_docs/plugin.py
Outdated
| @@ -34,6 +35,33 @@ class ComponentOption(Config): | |||
| git_url = config_options.Type(str, default="") | |||
| rest_api = config_options.Type(str, default="") | |||
|
|
|||
| _repository_dir = None | |||
src/pulp_docs/plugin.py
Outdated
Comment on lines
43
to
45
| raise RuntimeError( | ||
| "Can't get repository/component path before resolving the dir in the filesystem." | ||
| ) |
There was a problem hiding this comment.
What if we did not extend the mkdocs config class and instead wrapped a fat interface class around it?
I think we could prevent the "you need to post initialize this class before you can use it" situation.
Put another way: The easiest/safest way to maintain state is to never change it.
pedro-psb
force-pushed
the
add-fetch-functionality
branch
2 times, most recently
from
0beec0d to
99d32e4
Compare
pedro-psb
force-pushed
the
add-fetch-functionality
branch
3 times, most recently
from
556d490 to
4207db1
Compare
pedro-psb
force-pushed
the
add-fetch-functionality
branch
from
4207db1 to
1c3e210
Compare
mdellweg
approved these changes
May 2, 2025
Comment on lines
+264
to
+265
| if component: | ||
| loaded_components.append(component) |
There was a problem hiding this comment.
Why don't we handle the "draft logic" right here?
There was a problem hiding this comment.
(By doing the draft logic later, ) If draft is False, we get the cumulative list of missing plugins on the error message, instead of only the first one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.