Conversation
1 task
fischeti
changed the title
paulsc96
previously approved these changes
Mar 4, 2026
Member
paulsc96
left a comment
paulsc96
left a comment
There was a problem hiding this comment.
Not much to say here. a few lines of change, and a 700 line lock file. I guess we should stop worrying about microplastics, because soon we, like our codebases, will be 98% lockfile.
Jokes aside, see comments.
Member
|
Nonfree PR is merged. |
ci: Add uv venv setup for make-based build targets
docs: Mention pip as alternative to uv for Python setup
Contributor
Author
|
Thanks for the quick review! I addressed all the comments and bumped the nonfree commit |
paulsc96
reviewed
Mar 4, 2026
paulsc96
changed the title
venv with uv
paulsc96
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI currently fails on
maindue python dependencies, which is fixed in this PR. Further replaces the oldrequirements.txtwith a more modernpyproject.tomland usesuvto create a python virtual environment. The main advantage is that this allows to have a reproducible python environment for users, Github CI & internal Gitlab CI.Changed
requirements.txtwithpyproject.tomlflatdict(current failure) -> requires python 3.11 -> requiressetuptools<81(because of super old regtool)uv.lock0.31.0TODOs:
nonfreePR