Skip to content

Fix Rails deprecation warning in tag.rb trending query - #11880

Closed
ghost wants to merge 1 commit into
mainfrom
unknown repository
Closed

ghost wants to merge 1 commit into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Sep 16, 2026

Copy link
Copy Markdown

Summary

Fix Rails 6 deprecation warning in Tag.trending() method.

Changes

  • app/models/tag.rb: Wrap raw SQL 'count DESC' with Arel.sql() to resolve deprecation warning about dangerous query methods with non-attribute arguments.

Related

Fixes #4624

Wrap raw SQL 'count DESC' with Arel.sql() to resolve Rails 6 deprecation warning.

Fixes #4624
@welcome

welcome Bot commented Sep 16, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@ghost ghost closed this by deleting the head repository Sep 16, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve deprecation warning in preparation for Rails 6 (eventually)

0 participants