-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Github links to navbar/ footer to hopefully increase contributions #201
Conversation
Thanks @tomootes! Reviewing ASAP |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ruphy. Thanks for the suggestion, I accepted it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tomootes, I just pointing out a couple of catches
Oioi, quite some mistakes in a small PR. Note to self: check it again in the morning :) Should i rebase the branch? This cleans the commit history but wipes all proposed changes/ commits. Are you guys happy with it? |
@tomootes i changed i couple of things in the development section and moved it. It looks good to me. Let me know your take on the copyright thing and after that it's good to merge! |
Copyright thingy is fine! @bfabio lets merge 👍 |
🙌 |
I created this PR for two reasons;
I added three things in this PR:
Github logo with link to repo in navbar
![Screenshot from 2024-11-20 08-50-53](https://private-user-images.githubusercontent.com/4222167/387997860-ba2f62e9-9335-4c7c-9679-e4e3e16a2a14.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTgxNTMsIm5iZiI6MTczOTM1Nzg1MywicGF0aCI6Ii80MjIyMTY3LzM4Nzk5Nzg2MC1iYTJmNjJlOS05MzM1LTRjN2MtOTY3OS1lNGUzZTE2YTJhMTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMTA1NzMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTMzYWY0ZTM0ZjViZWMzODUxYjdlNmRlOWNkOWFhODAyN2U3MzYxNThhMjdjZTZlN2RmZjJlMzRhYTI5ZjlhMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ._Fpmli9Os9cwqzhc6Azy5vpS5qKww6KCdvMf-efTKp8)
Link to Authors.md in footer + link to Github again
![Screenshot from 2024-11-20 08-50-32](https://private-user-images.githubusercontent.com/4222167/387998279-864c8176-9d61-4b89-a283-c3224d8036e5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTgxNTMsIm5iZiI6MTczOTM1Nzg1MywicGF0aCI6Ii80MjIyMTY3LzM4Nzk5ODI3OS04NjRjODE3Ni05ZDYxLTRiODktYTI4My1jMzIyNGQ4MDM2ZTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMTA1NzMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGIyMzYwYTc4NmYwZjYxZGRkYjU2OTI2MzdlNTY4ZTNjMjE0NDQ1Y2VkZGNiYmIzZTRhY2M3ZWEyYTUyM2M4NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Ak102XMHxu9UPXJMGZo1ErKamTkAz12R7NI-2nYktOA)
Added info to readme.md on how to develop locally
This answers the question immediately, that the website is build on Sphinx.
Concessions
Take note that i had to accept some concessions: