Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cde6a4389c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb8c92e4a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- block global delete when virtual editor focus promotion is pending - replace bool bundles with typed focus-state routing helpers - split explicit-vs-implicit clipboard create policy - add regressions for whitespace explicit paste and focus guards
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
- remove right-to-left row container that caused title overlay hit interception - make row title label non-interactive so button receives clicks across full width - preserve right-aligned language column while keeping title left-aligned
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
This branch closes a set of compounding GUI reliability issues that all hit the same user surface: typing, pasting, and navigating text in the editor. The core goal was to make LocalPaste's editor behavior predictable under real-world muscle memory, then remove the legacy paths that were causing inconsistent behavior and maintenance drag.
What this changes
This PR unifies the app around a virtual-editor-first model and hardens the full editing flow end-to-end:
Editing correctness
Home/Endbehavior now follows visual-row semantics and is locked by tests.Ctrl/Cmd+Deleteno longer hijacks editor text operations when any text input context owns keyboard focus.GUI consistency
Architecture simplification
Release/packaging reliability
Result
Mainline behavior is now centered on one editor model with platform-correct navigation, safer shortcut routing, and fewer split code paths. This reduces both user-facing paper cuts and regression surface.
Validation
Full workspace/tooling/test validation was run, including GUI keyboard/focus suites, full
localpaste_guitests, policy checks (check-loc, AST dupes), and strict rustdoc checks.Follow-up Checklist (next PR, cleanup-focused)
EditorModeplumbing to a single content-editor path.