Allow arbitrary bytes as upstream name of grpc call #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy allows the upstream to be serialized GrpcService message, but the proxy-wasm API allows only
&str
. (why use GrpcService message – to be able to connect to arbitrary upstream not predefined in envoy's clusters). This functionality seems to be supported by envoy so it makes sense to expose it in SDK.This is obviously a breaking change, not sure how to make it non-breaking though (I thought about
impl AsRef<u8>
, but that would break object safety, I guess. Perhaps a separate trait method would a better solution?)I've also looked a bit in the spec, in which the
upstream
argument is calledgrpc_service
(hinting the use of formentioned GrpcService message), but in your PR, this argument is called justupstream_name
. So thus I'm confused on the state of that feature, can you shed some light there?