Skip to content

Conversation

@pedrooot
Copy link
Member

@pedrooot pedrooot commented Nov 28, 2025

Description

This PR updates the logic for counting passed_findings & total_findings to match the one used for the PDF reporting (the valid one).

Steps to review

Please add a detailed description of how to review this PR.

Checklist

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team as a code owner November 28, 2025 13:22
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

🔒 Container Security Scan

Image: prowler-api:3e8c577
Last scan: 2025-11-28 14:05:51 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 4
Total 4

3 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.57%. Comparing base (b2abdbe) to head (cb187e0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9348      +/-   ##
==========================================
- Coverage   92.99%   92.57%   -0.43%     
==========================================
  Files         125      154      +29     
  Lines        2998    21144   +18146     
==========================================
+ Hits         2788    19574   +16786     
- Misses        210     1570    +1360     
Flag Coverage Δ
api 92.57% <100.00%> (?)
prowler-py3.10-gcp ?
prowler-py3.11-gcp ?
prowler-py3.12-gcp ?
prowler-py3.9-gcp ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 92.57% <100.00%> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pedrooot pedrooot added the backport-to-v5.14 Backport PR to the v5.14 branch label Nov 28, 2025
@pedrooot pedrooot merged commit d3a000c into master Dec 1, 2025
31 of 32 checks passed
@pedrooot pedrooot deleted the fix-threatscore-k8s branch December 1, 2025 08:11
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 1, 2025
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v5.14

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v5.14 Backport PR to the v5.14 branch component/api was-backported The PR was successfully backported to the target branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants