fix(ui): collection of UI bug fixes and improvements #9346
+566
−409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add coordinate mappings for all supported providers: - OracleCloud: 28 regions with proper coordinates - Kubernetes: global fallback (can run anywhere) - M365: global fallback (Microsoft datacenters) - GitHub: global fallback - IAC: global fallback (code scanning, no regions) - MongoDBAtlas: global fallback (inherits from cloud provider) The implementation includes automatic fallback to 'global' coordinates for providers that don't have specific regional mappings, ensuring all providers can be displayed on the map.
GCP returns 'global' as the region for certain services. Add global coordinate (Google HQ in Mountain View, CA) to GCP region coordinates and provider aliases to ensure GCP data appears on the threat map.
- Change region filter to use actual region codes instead of providers - Hide global region dots from map (no clear geographic position) - Show global first in region dropdown - Paint entire map red when global region is selected - Sort regions alphabetically with global at top
Compute filtered locations inside useEffect instead of using derived filteredLocations array. The old approach created new array references on each render, causing the useEffect to re-run infinitely on hover.
- Extract types/constants to threat-map.types.ts (65 lines) - Extract utility functions to threat-map.utils.ts (73 lines) - Simplify main component with LocationDetails sub-component - Use named d3 imports (geoPath, geoNaturalEarth1) - Replace inline styles with Tailwind semantic color classes - Reduce main component from 635 to ~465 lines
- Update pagination to use shadcn select component with proper design tokens - Fix regions 'Select All' to show all values as selected when no filter param exists
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
|
Please add an entry to the corresponding |
Contributor
🔒 Container Security ScanImage: ✅ No Vulnerabilities DetectedThe container image passed all security checks. No known CVEs were found.📋 Resources:
|
Alan-TheGentleman
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses multiple UI bugs and improvements identified during review. The fixes span across various components including the threat map, service watchlist, compliance filters, and pagination.
Description
Threat Map Improvements
Service Watchlist
Compliance Page
Pagination
Steps to review
Threat Map: Navigate to Overview and check the threat map with different providers (AWS, Azure, GCP). Verify:
Service Watchlist: Check Overview page - service watchlist should not show icons
Compliance Regions Filter: Go to Compliance detail page, check:
Pagination: Check any table with pagination - rows per page dropdown should have updated styling matching the design system
Checklist
UI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.