Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR copies the full boot sequence from main.py into repl.py to provide REPL access for manual hardware testing, and updates the README to clarify usage and target boards.
- Added full initialization and boot logic to
repl.pyto mirror v5a behavior. - Updated imports and component setup in
repl.py. - Refined README description and usage instructions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| repl.py | Inlined boot sequence, added hardware initialization, and set up REPL context. |
| README.md | Clarified reference software usage and target boards; minor grammar updates. |
Comments suppressed due to low confidence (1)
repl.py:90
- [nitpick] The variable name
fis ambiguous. Rename it to something more descriptive likefuncsorcommand_functions.
f = functions.functions(
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Hey @DavidUniack if you happen to still have a V4x board on hand you could try this out with it would be quite appreciated! |
hrfarmer
requested changes
Jun 4, 2025
Member
hrfarmer
left a comment
hrfarmer
left a comment
There was a problem hiding this comment.
Tested on my board and this works good, would just remove the block I highlighted
Removed unnecessary initial boot sequence Co-authored-by: aychar <58487401+hrfarmer@users.noreply.github.com>
Mikefly123
force-pushed
the
update-repl-functionality
branch
from
554efc7 to
7aaace1
Compare
hrfarmer
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a pretty straight forward PR. To mirror the way the v5a repo is current setup, I propose that we take the entire boot sequence from
main.pyand just copy / paste it intorepl.py. This is a not a particularly elegant solution to giving functionality to theREPL, but it does provide us with a stop gap for allowing people new to the Flight Controller Boards to run some manual tests on hardware to build out some knowledge of how things work!How was this tested
I don't have a board at home with me to test this today, but these changes worked when ran in the lab yesterday. I can verify again when I go in tomorrow.