Skip to content

fix: missing minZoom on towns #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: missing minZoom on towns #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tiles/src/main/java/com/protomaps/basemap/layers/Places.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,11 @@ public Places(CountryCoder countryCoder) {
rule(
with("place", "city"),
without("population"),
use("population", 5000),
use("population", 50000),
Copy link
Collaborator

@nvkelso nvkelso Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Per the original code, this should have been 5000 -- because most big cities already have population values. Please revise.
  • The minZoom is fine at 8 (just 1 more than with populations). Your change is good.
  • (The later population_rank should be set as well so client side collisions are rational.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The population for towns is set to 10k tho, shouldn't cities be higher? Or at least the same?
Note that I didn't touch the minZoom for cities, the diff is just rendering a bit confusingly here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvkelso The current behaviour is incorrect since some capitals (!) are not shown, while some small, unrelated villages are visible. Could you give us any guidance what a fitting fix would be? We're open to making a PR.

use("minZoom", 8)
),
rule(
Copy link
Collaborator

@nvkelso nvkelso Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have a separate rule for towns with population – they are used interchangeably with cities outside of Europe. Please remove.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to OSM wiki, the median population of cities is 130k, whereas for towns it's ranging (by country) from 3k to 35k. While cities and towns may be interchangeably used sometimes, I still feel like towns are generally of less importance, wouldn't you agree?

At zoom 7, we're displaying small towns like Sursee (10k population) alongside big cities, which creates a very cluttered map unlike most other styles. Towns with a population are literally displayed before cities without a population.

with("place", "town"),
use("minZoom", 8)
),
rule(
Expand Down