Skip to content

Incorrect values on parameter prooph_event_store.projection_managers #54

Open
Open
Incorrect values on parameter prooph_event_store.projection_managers#54

Description

@brunowowk
brunowowk
opened on Dec 14, 2018

In this excerpt I believe the prooph_event_store.projection_managers was supposed to contain the projection managers names, but currently they're prepended with prooph_event_store:

event-store-symfony-bundle/src/DependencyInjection/ProophEventStoreExtension.php

Lines 64 to 80 in 5f0aeca

foreach ($config['projection_managers'] as $projectionManagerName => $projectionManagerConfig) {
$projectionManagerId = "prooph_event_store.projection_manager.$projectionManagerName";
self::defineProjectionManager($container, $projectionManagerId, $projectionManagerConfig);
[$projectionManagerForProjectionsLocator, $projectionsLocator, $readModelsLocator] = self::collectProjectionsForLocators(
$projectionManagerConfig['projections'],
$projectionManagerId,
$projectionManagerForProjectionsLocator,
$projectionsLocator,
$readModelsLocator
);
$projectionManagers[$projectionManagerName] = "prooph_event_store.$projectionManagerName";
$projectionManagersLocator[$projectionManagerName] = new Reference($projectionManagerId);
}
$container->setParameter('prooph_event_store.projection_managers', $projectionManagers);

That parameter is only used on the ProjectionNamesCommand, so maybe it would make more sense to include only the names.

Activity

  1. codeliner commented on Dec 17, 2018

    @codeliner
    codeliner
    on Dec 17, 2018
    Member

    ping @UFOMelkor: any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions