Suppress or fix miscellaneous spotbugs warnings

bootstrap/src/main/java/com/proofpoint/bootstrap/LifeCycleMethods.java

@@ -22,7 +22,6 @@
 
 import java.lang.annotation.Annotation;
 import java.lang.reflect.Method;
-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashSet;
 import java.util.Set;
@@ -38,16 +37,22 @@ class LifeCycleMethods
         addLifeCycleMethods(clazz, new HashSet<>(), new HashSet<>());
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     boolean hasFor(Class<? extends Annotation> annotation)
     {
         Collection<Method> methods = methodMap.get(annotation);
-        return (methods != null) && (!methods.isEmpty());
+        return !methods.isEmpty();
     }
 
     Collection<Method> methodsFor(Class<? extends Annotation> annotation)
     {
-        Collection<Method> methods = methodMap.get(annotation);
-        return (methods != null) ? methods : new ArrayList<>();
+        return methodMap.get(annotation);
     }
 
     private void addLifeCycleMethods(Class<?> clazz, Set<String> usedConstructNames, Set<String> usedDestroyNames)

configuration/src/main/java/com/proofpoint/configuration/ConfigurationMetadata.java

@@ -128,6 +128,13 @@ else if (!this.defunctConfig.add(defunct)) {
         }
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     public static boolean isConfigClass(Class<?> classz)
     {
         for (Method method : classz.getDeclaredMethods()) {

discovery/src/main/java/com/proofpoint/discovery/client/ServiceDescriptors.java

@@ -71,6 +71,13 @@ public ServiceDescriptors(String type,
         }
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     public String getType()
     {
         return type;

event/src/main/java/com/proofpoint/event/client/EventJsonSerializer.java

@@ -63,6 +63,13 @@ else if (token.size() == 1) {
         }
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     @Override
     public Class<T> handledType()
     {

http-client/src/main/java/com/proofpoint/http/client/FullSmileResponseHandler.java

@@ -46,6 +46,13 @@ public static <T> FullSmileResponseHandler<T> createFullSmileResponseHandler(Jso
         return new FullSmileResponseHandler<>(jsonCodec);
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     private final JsonCodec<T> jsonCodec;
 
     private FullSmileResponseHandler(JsonCodec<T> jsonCodec)

http-client/src/main/java/com/proofpoint/http/client/HttpUriBuilder.java

@@ -58,6 +58,13 @@ private HttpUriBuilder(URI previous)
         params.putAll(parseParams(previous.getRawQuery()));
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     public static HttpUriBuilder uriBuilder()
     {
         return new HttpUriBuilder();

http-client/src/main/java/com/proofpoint/http/client/balancing/HttpServiceBalancerImpl.java

@@ -76,6 +76,13 @@ public HttpServiceBalancerImpl(String description, HttpServiceBalancerStats http
         this.ticker = requireNonNull(ticker, "ticker is null");
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     @Override
     public HttpServiceAttempt createAttempt()
     {

http-client/src/main/java/com/proofpoint/http/client/jetty/JettyHttpClient.java

@@ -133,7 +133,8 @@ public JettyHttpClient(String name, HttpClientConfig config)
     public JettyHttpClient(
         String name,
         HttpClientConfig config,
-        Iterable<? extends HttpRequestFilter> requestFilters) {
+        Iterable<? extends HttpRequestFilter> requestFilters)
+    {
         this(name, config, DEFAULT_CLIENT_OPTIONS, requestFilters);
     }
 
@@ -331,6 +332,13 @@ public JettyHttpClient(
          });
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     private static QueuedThreadPool createExecutor(String name, int minThreads, int maxThreads)
     {
         try {

http-server/src/main/java/com/proofpoint/http/server/HttpServer.java

@@ -267,6 +267,13 @@ protected void runJob(Runnable job)
                 .map(date -> ZonedDateTime.ofInstant(date.toInstant(), ZoneId.systemDefault()));
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     private ServerConnector createHttpsServerConnector(HttpServerConfig config, ServerSocketChannel serverSocketChannel, HttpConfiguration configuration, Executor threadPool, int acceptors, int selectors)
             throws IOException
     {

jmx-http/src/main/java/com/proofpoint/jmx/MBeanRepresentation.java

@@ -93,6 +93,13 @@ public MBeanRepresentation(MBeanServer mbeanServer, ObjectName objectName, Objec
         this.operations = operations.build();
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     @JsonProperty
     public ObjectName getObjectName()
     {

jmx/src/main/java/com/proofpoint/jmx/JmxAgent9.java

@@ -100,6 +100,13 @@ else if (configuredRegistryPort != null) {
         }
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     @Nullable
     @Override
     public JMXServiceURL getUrl()

jmx/src/main/java/com/proofpoint/jmx/JmxInspector.java

@@ -112,6 +112,13 @@ public JmxInspector(Injector injector)
         inspectorRecords = builder.build();
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     @Override
     public Iterator<InspectorRecord> iterator()
     {

launcher/src/main/java/com/proofpoint/launcher/Main.java

@@ -76,6 +76,13 @@ private Main()
     {
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     public static void main(String[] args)
     {
         Cli<Runnable> cli = Cli.<Runnable>builder("launcher")

launcher/src/main/java/com/proofpoint/launcher/PidFile.java

@@ -76,6 +76,13 @@ class PidFile implements PidStatusSource
         }
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     void indicateStarting()
             throws AlreadyRunningError
     {

log/pom.xml

@@ -64,6 +64,12 @@
             <artifactId>jakarta.annotation-api</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>com.github.spotbugs</groupId>
+            <artifactId>spotbugs-annotations</artifactId>
+            <optional>true</optional>
+        </dependency>
+
         <!-- for testing -->
         <dependency>
             <groupId>com.proofpoint.platform</groupId>

log/src/main/java/com/proofpoint/log/Logging.java

@@ -31,6 +31,7 @@
 import com.proofpoint.configuration.PropertiesBuilder;
 import com.proofpoint.units.DataSize;
 import com.proofpoint.units.Duration;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.io.BufferedWriter;
 import java.io.File;
@@ -98,6 +99,7 @@ public class Logging
      *
      * @return the logging system singleton
      */
+    @SuppressFBWarnings("MS_EXPOSE_REP")
     public static synchronized Logging initialize()
     {
         if (instance == null) {
@@ -117,6 +119,13 @@ private Logging()
         rewireStdStreams();
     }
 
+    // Protect against finalizer attacks, as constructor can throw exception.
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize()
+    {
+    }
+
     @SuppressWarnings("IOResourceOpenedButNotSafelyClosed")
     private void rewireStdStreams()
     {

reporting-client/src/main/java/com/proofpoint/reporting/SplunkObservabilityClient.java

@@ -96,7 +96,7 @@ public void report(long systemTimeMillis, Table<String, Map<String, String>, Obj
         //Reporting events
         reportEach(systemTimeMillis, collectedData.cellSet().stream()
                 .filter(cell -> !(cell.getValue() instanceof Number))
-                .filter(cell -> cell.getValue() != "")
+                .filter(cell -> !cell.getValue().equals(""))
                 .collect(ImmutableTable.toImmutableTable(
                         Table.Cell::getRowKey,
                         Table.Cell::getColumnKey,

testing/src/main/java/com/proofpoint/testing/EquivalenceTester.java

@@ -99,7 +99,7 @@ public void check()
         }
 
         @SuppressWarnings({"ObjectEqualsNull", "SelfEquals"})
-        @SuppressFBWarnings({"EC_NULL_ARG","RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"})
+        @SuppressFBWarnings({"DCN_NULLPOINTER_EXCEPTION","EC_NULL_ARG","RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"})
         private List<ElementCheckFailure> checkEquivalence()
         {
             ImmutableList.Builder<ElementCheckFailure> errors = new ImmutableList.Builder<>();

trace-token/pom.xml

@@ -27,6 +27,12 @@
             <artifactId>jakarta.annotation-api</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>com.github.spotbugs</groupId>
+            <artifactId>spotbugs-annotations</artifactId>
+            <optional>true</optional>
+        </dependency>
+
         <!-- for testing -->
         <dependency>
             <groupId>org.testng</groupId>

trace-token/src/main/java/com/proofpoint/tracetoken/TraceToken.java

@@ -20,6 +20,7 @@
 import com.google.common.collect.ForwardingMap;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Maps;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.util.Map;
 
@@ -56,6 +57,7 @@ protected Map<String, String> delegate()
     }
 
     @Override
+    @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     public String toString()
     {
         if (delegate.size() == 1) {