commentMonitor: Refactor, cleanup and rename to comment-monitor; test prod config on CI #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
commentmonitor2
branch
from
4967bb5 to
f756df4
Compare
|
Will deploy to prod for testing soon, but please review. |
bwplotka
force-pushed
the
commentmonitor2
branch
from
f756df4 to
192aa16
Compare
kakkoyun
approved these changes
Dec 12, 2024
bwplotka
force-pushed
the
commentmonitor2
branch
9 times, most recently
from
d2772b6 to
179aeba
Compare
|
Deployed and tested: prometheus/prometheus#15487 |
Some examples on how old one works (vs the unit test I added): prometheus/prometheus#15487 Signed-off-by: bwplotka <[email protected]>
bwplotka
force-pushed
the
commentmonitor2
branch
from
179aeba to
9203786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO functional changes to comment monitoring in this PR
Some examples on how old one works (vs the unit test I added): prometheus/prometheus#15487
This is a prerequisite to any improvements in the direction of prometheus/proposals#41
As a nice bonus I made sure we also test our production config on CI 💪🏽