Skip to content

Commit

Permalink
Small fix to prombench Makefile to adjust for alpine docker image. (#813
Browse files Browse the repository at this point in the history
)

No openssh installed, and fingerprint ask, so switching to HTTPs for git.

alpine mktemp does not have -t apparently too.

Signed-off-by: bwplotka <[email protected]>
  • Loading branch information
bwplotka authored Dec 20, 2024
1 parent 40ed81c commit b90e694
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions prombench/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ cluster_delete:
BENCHMARK_DIRECTORY := $(if $(BENCHMARK_DIRECTORY),$(BENCHMARK_DIRECTORY),manifests/prombench)
# /prombench <...> --bench.version
BENCHMARK_VERSION := $(if $(BENCHMARK_VERSION),$(BENCHMARK_VERSION),master)
PROMBENCH_GIT_REPOSITORY ?= git@github.com:prometheus/test-infra.git
PROMBENCH_GIT_REPOSITORY ?= https://github.com/prometheus/test-infra.git
PROMBENCH_DIR ?= .

# maybe_pull_custom_version allows custom benchmarking as designed in
Expand All @@ -50,7 +50,7 @@ ifeq (${BENCHMARK_VERSION},master)
@echo ">> Using standard benchmark configuration, from the docker image"
else
@echo ">> Git pulling custom benchmark configuration from the ${BENCHMARK_VERSION}"
@$(eval $@_TMP_DIR=$(shell mktemp -d -t "prombench"))
@$(eval $@_TMP_DIR=$(shell mktemp -d))
cd ${$@_TMP_DIR} && git clone ${PROMBENCH_GIT_REPOSITORY}
ifeq ($(subst @,,${BENCHMARK_VERSION}),${BENCHMARK_VERSION})
@echo ">> --bench.version is a branch, reseting to origin/${BENCHMARK_VERSION}"
Expand Down

0 comments on commit b90e694

Please sign in to comment.