-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow make docker-generate
to work with SELINUX
#1054
Conversation
ebf6a5e
to
af96b00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a little more description of why this is needed?
Without this change when running on a system using SELINUX you will receive an error like this: <snip> ts=2023-11-27T15:48:48.150Z caller=net_snmp.go:175 level=info msg="Loading MIBs" from=mibs ts=2023-11-27T15:48:48.150Z caller=main.go:134 level=error msg="Error generating config netsnmp" err="unable to determine absolute path for output" make: *** [Makefile:92: docker-generate] Error 1 Information on the ':Z' option at: https://docs.docker.com/storage/bind-mounts/#configure-the-selinux-label Signed-off-by: John L. Villalovos <[email protected]>
af96b00
to
2c8b55d
Compare
Done @SuperQ Thanks. |
This part in the linked documentation is a bit scary:
I know is a bit late (this PR was already merged), but doing it like Note that they use |
@hhromic Yea, I agree, I should have read the Docker documentation more closely. Would you mind opening a fix PR? |
Sure, I will open a PR with that approach. 👍 |
Without this change when running on a system using SELINUX you will
receive an error like this:
Information on the ':Z' option at:
https://docs.docker.com/storage/bind-mounts/#configure-the-selinux-label