netstat_freebsd: add new metrics #3334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the code testable and more maintainable: - Encapsulate all the CGO code so it can be tested - Fix the test file (it wasn't compiling) and improve tests - Mock the data returned by unix.SysctlRaw so the code can be tested without actually calling sysctl. No change in behavior intended Signed-off-by: Danilo Egea Gondolfo <[email protected]>
Metrics added: - ip4_transmit_packets_total - ip4_transmit_raw_packets_total - ip4_receive_packets_total - ip4_receive_fragments_total - ip4_forward_total - ip4_fast_forward_total - ip4_delivered_total Signed-off-by: Danilo Egea Gondolfo <[email protected]>
Metrics added: - ip6_transmit_packets_total - ip6_transmit_raw_packets_total - ip6_receive_packets_total - ip6_receive_fragments_total - ip6_forward_total - ip6_delivered_total Signed-off-by: Danilo Egea Gondolfo <[email protected]>
Metrics added: - udp_transmit_packets_total - udp_receive_packets_total Signed-off-by: Danilo Egea Gondolfo <[email protected]>
Metric added (gauge):
node_netstat_tcp_connections{state="CLOSED"}
node_netstat_tcp_connections{state="CLOSE_WAIT"}
node_netstat_tcp_connections{state="CLOSING"}
node_netstat_tcp_connections{state="ESTABLISHED"}
node_netstat_tcp_connections{state="FIN_WAIT_1"}
node_netstat_tcp_connections{state="FIN_WAIT_2"}
node_netstat_tcp_connections{state="LAST_ACK"}
node_netstat_tcp_connections{state="LISTEN"}
node_netstat_tcp_connections{state="SYN_RCVD"}
node_netstat_tcp_connections{state="SYN_SENT"}
node_netstat_tcp_connections{state="TIME_WAIT"}
Signed-off-by: Danilo Egea Gondolfo <[email protected]>
daniloegea
force-pushed
the
netstat_freebsd
branch
from
304a3b0 to
4bb3f03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of new metrics to the
netstat_freebsdmodule.The first commit is a refactoring to make it easier to add new metrics. It also fixes the netstat_freebsd tests, which were completely broken. I added a function to return fake raw data so the code can be tested without calling the low level functions.
The new metrics are:
IPv4
IPv6
UDP
TCP states
Each commit has the list of metrics added, but here is the full list (including the ones that already existed):