Skip to content

[FEATURE] Add Miimon linux bonding metrics #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[FEATURE] Add Miimon linux bonding metrics #3326

wants to merge 3 commits into from

Conversation

JustHumanz
Copy link

Add :

# HELP node_bonding_miimon MII link monitoring frequency in milliseconds.
# TYPE node_bonding_miimon gauge
node_bonding_miimon{master="bond0"} 200

From

/sys/class/net/<bonding>/bonding/miimon

pr context:

SuperQ
SuperQ requested changes May 5, 2025
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's not exactly in scope for this, we really should refactor this collector to use https://github.com/prometheus/procfs.

@JustHumanz JustHumanz requested a review from SuperQ May 8, 2025 18:47
JustHumanz added 3 commits May 19, 2025 15:15
@JustHumanz
Add Miimon metrics
f346179 
Signed-off-by: JustHumanz <[email protected]>
@JustHumanz
add miimon in sys.ttar
ea687a3 
Signed-off-by: JustHumanz <[email protected]>
@JustHumanz
refactor readBondingStats
7df3a8b 
Signed-off-by: JustHumanz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ Awaiting requested review from SuperQ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustHumanz @SuperQ