Skip to content

added md disks in down state #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
+220 −3
Open

added md disks in down state #3007

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
21be960
added md disks in down state
Finomosec Apr 29, 2024
58f48d1
added node_md_sync_minutes_remaining, node_md_blocks_synced_speed and…
Finomosec May 1, 2024
27b93f8
fixed unit-test expected output
Finomosec May 1, 2024
3179601
fixed unit-test expected output
Finomosec May 1, 2024
f21e3b5
Update mdadm_linux.go
May 1, 2024
dd0a449
Update mdadm_linux.go
May 1, 2024
70a889f
fixed unit-test expected output
Finomosec May 1, 2024
9b3de10
fixed unit-test expected output
Finomosec May 1, 2024
4d743c4
Update collector/mdadm_linux.go
May 9, 2024
6df2222
Update collector/mdadm_linux.go
May 9, 2024
cf0dffe
fixed unit-test expected output
Finomosec May 9, 2024
af65f85
Merge branch 'prometheus:master' into master
Oct 16, 2024
de82d1a
Added DisksRecovering
Finomosec Oct 16, 2024
e020eb4
Updated procfs to used patched version
Finomosec Oct 16, 2024
01a9d66
üatched procfs
Finomosec Oct 16, 2024
5586487
added dep
Finomosec Oct 16, 2024
847e8ca
fixed disk status - renamed from recovering to replacing
Jul 13, 2025
1d11514
Merge branch 'master' into master
Finomosec Sep 17, 2025
626fd3f
fixed DisksReplacing, added reshaping
Finomosec Sep 17, 2025
bcbe1d7
reverted changes for local patch
Finomosec Sep 17, 2025
843a753
fixed imports
Finomosec Sep 17, 2025
0840dde
fixed checkstyle errors
Finomosec Sep 17, 2025
eb7055d
Merge branch 'prometheus:master' into master
Finomosec Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions collector/fixtures/e2e-64k-page-output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,57 +1559,112 @@ node_md_blocks_synced{device="md6"} 1.6775552e+07
node_md_blocks_synced{device="md7"} 7.813735424e+09
node_md_blocks_synced{device="md8"} 1.6775552e+07
node_md_blocks_synced{device="md9"} 0
# HELP node_md_blocks_synced_percent Percentage of blocks synced on device.
# TYPE node_md_blocks_synced_percent gauge
node_md_blocks_synced_percent{device="md0"} 0
node_md_blocks_synced_percent{device="md00"} 0
node_md_blocks_synced_percent{device="md10"} 0
node_md_blocks_synced_percent{device="md101"} 0
node_md_blocks_synced_percent{device="md11"} 0
node_md_blocks_synced_percent{device="md12"} 0
node_md_blocks_synced_percent{device="md120"} 0
node_md_blocks_synced_percent{device="md126"} 0
node_md_blocks_synced_percent{device="md127"} 0
node_md_blocks_synced_percent{device="md201"} 5.7
node_md_blocks_synced_percent{device="md219"} 0
node_md_blocks_synced_percent{device="md3"} 0
node_md_blocks_synced_percent{device="md4"} 0
node_md_blocks_synced_percent{device="md6"} 8.5
node_md_blocks_synced_percent{device="md7"} 0
node_md_blocks_synced_percent{device="md8"} 8.5
node_md_blocks_synced_percent{device="md9"} 0
# HELP node_md_blocks_synced_speed current sync speed (in Kilobytes/sec)
# TYPE node_md_blocks_synced_speed gauge
node_md_blocks_synced_speed{device="md0"} 0
node_md_blocks_synced_speed{device="md00"} 0
node_md_blocks_synced_speed{device="md10"} 0
node_md_blocks_synced_speed{device="md101"} 0
node_md_blocks_synced_speed{device="md11"} 0
node_md_blocks_synced_speed{device="md12"} 0
node_md_blocks_synced_speed{device="md120"} 0
node_md_blocks_synced_speed{device="md126"} 0
node_md_blocks_synced_speed{device="md127"} 0
node_md_blocks_synced_speed{device="md201"} 114176
node_md_blocks_synced_speed{device="md219"} 0
node_md_blocks_synced_speed{device="md3"} 0
node_md_blocks_synced_speed{device="md4"} 0
node_md_blocks_synced_speed{device="md6"} 259783
node_md_blocks_synced_speed{device="md7"} 0
node_md_blocks_synced_speed{device="md8"} 259783
node_md_blocks_synced_speed{device="md9"} 0
# HELP node_md_disks Number of active/failed/spare disks of device.
# TYPE node_md_disks gauge
node_md_disks{device="md0",state="active"} 2
node_md_disks{device="md0",state="down"} 0
node_md_disks{device="md0",state="failed"} 0
node_md_disks{device="md0",state="spare"} 0
node_md_disks{device="md00",state="active"} 1
node_md_disks{device="md00",state="down"} 0
node_md_disks{device="md00",state="failed"} 0
node_md_disks{device="md00",state="spare"} 0
node_md_disks{device="md10",state="active"} 2
node_md_disks{device="md10",state="down"} 0
node_md_disks{device="md10",state="failed"} 0
node_md_disks{device="md10",state="spare"} 0
node_md_disks{device="md101",state="active"} 3
node_md_disks{device="md101",state="down"} 0
node_md_disks{device="md101",state="failed"} 0
node_md_disks{device="md101",state="spare"} 0
node_md_disks{device="md11",state="active"} 2
node_md_disks{device="md11",state="down"} 0
node_md_disks{device="md11",state="failed"} 1
node_md_disks{device="md11",state="spare"} 2
node_md_disks{device="md12",state="active"} 2
node_md_disks{device="md12",state="down"} 0
node_md_disks{device="md12",state="failed"} 0
node_md_disks{device="md12",state="spare"} 0
node_md_disks{device="md120",state="active"} 2
node_md_disks{device="md120",state="down"} 0
node_md_disks{device="md120",state="failed"} 0
node_md_disks{device="md120",state="spare"} 0
node_md_disks{device="md126",state="active"} 2
node_md_disks{device="md126",state="down"} 0
node_md_disks{device="md126",state="failed"} 0
node_md_disks{device="md126",state="spare"} 0
node_md_disks{device="md127",state="active"} 2
node_md_disks{device="md127",state="down"} 0
node_md_disks{device="md127",state="failed"} 0
node_md_disks{device="md127",state="spare"} 0
node_md_disks{device="md201",state="active"} 2
node_md_disks{device="md201",state="down"} 0
node_md_disks{device="md201",state="failed"} 0
node_md_disks{device="md201",state="spare"} 0
node_md_disks{device="md219",state="active"} 0
node_md_disks{device="md219",state="down"} 0
node_md_disks{device="md219",state="failed"} 0
node_md_disks{device="md219",state="spare"} 3
node_md_disks{device="md3",state="active"} 8
node_md_disks{device="md3",state="down"} 0
node_md_disks{device="md3",state="failed"} 0
node_md_disks{device="md3",state="spare"} 2
node_md_disks{device="md4",state="active"} 0
node_md_disks{device="md4",state="down"} 0
node_md_disks{device="md4",state="failed"} 1
node_md_disks{device="md4",state="spare"} 1
node_md_disks{device="md6",state="active"} 1
node_md_disks{device="md6",state="down"} 1
node_md_disks{device="md6",state="failed"} 1
node_md_disks{device="md6",state="spare"} 1
node_md_disks{device="md7",state="active"} 3
node_md_disks{device="md7",state="down"} 1
node_md_disks{device="md7",state="failed"} 1
node_md_disks{device="md7",state="spare"} 0
node_md_disks{device="md8",state="active"} 2
node_md_disks{device="md8",state="down"} 0
node_md_disks{device="md8",state="failed"} 0
node_md_disks{device="md8",state="spare"} 2
node_md_disks{device="md9",state="active"} 4
node_md_disks{device="md9",state="down"} 0
node_md_disks{device="md9",state="failed"} 2
node_md_disks{device="md9",state="spare"} 1
# HELP node_md_disks_required Total number of disks of device.
Expand Down Expand Up @@ -1718,6 +1773,25 @@ node_md_state{device="md9",state="check"} 0
node_md_state{device="md9",state="inactive"} 0
node_md_state{device="md9",state="recovering"} 0
node_md_state{device="md9",state="resync"} 1
# HELP node_md_sync_time_remaining_seconds Estimated finishing time for current sync in seconds.
# TYPE node_md_sync_time_remaining_seconds gauge
node_md_sync_time_remaining_seconds{device="md0"} 0
node_md_sync_time_remaining_seconds{device="md00"} 0
node_md_sync_time_remaining_seconds{device="md10"} 0
node_md_sync_time_remaining_seconds{device="md101"} 0
node_md_sync_time_remaining_seconds{device="md11"} 0
node_md_sync_time_remaining_seconds{device="md12"} 0
node_md_sync_time_remaining_seconds{device="md120"} 0
node_md_sync_time_remaining_seconds{device="md126"} 0
node_md_sync_time_remaining_seconds{device="md127"} 0
node_md_sync_time_remaining_seconds{device="md201"} 12
node_md_sync_time_remaining_seconds{device="md219"} 0
node_md_sync_time_remaining_seconds{device="md3"} 0
node_md_sync_time_remaining_seconds{device="md4"} 0
node_md_sync_time_remaining_seconds{device="md6"} 1020
node_md_sync_time_remaining_seconds{device="md7"} 0
node_md_sync_time_remaining_seconds{device="md8"} 1020
node_md_sync_time_remaining_seconds{device="md9"} 0
# HELP node_memory_Active_anon_bytes Memory information field Active_anon_bytes.
# TYPE node_memory_Active_anon_bytes gauge
node_memory_Active_anon_bytes 2.068484096e+09
Expand Down
74 changes: 74 additions & 0 deletions collector/fixtures/e2e-output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,57 +1581,112 @@ node_md_blocks_synced{device="md6"} 1.6775552e+07
node_md_blocks_synced{device="md7"} 7.813735424e+09
node_md_blocks_synced{device="md8"} 1.6775552e+07
node_md_blocks_synced{device="md9"} 0
# HELP node_md_blocks_synced_percent Percentage of blocks synced on device.
# TYPE node_md_blocks_synced_percent gauge
node_md_blocks_synced_percent{device="md0"} 0
node_md_blocks_synced_percent{device="md00"} 0
node_md_blocks_synced_percent{device="md10"} 0
node_md_blocks_synced_percent{device="md101"} 0
node_md_blocks_synced_percent{device="md11"} 0
node_md_blocks_synced_percent{device="md12"} 0
node_md_blocks_synced_percent{device="md120"} 0
node_md_blocks_synced_percent{device="md126"} 0
node_md_blocks_synced_percent{device="md127"} 0
node_md_blocks_synced_percent{device="md201"} 5.7
node_md_blocks_synced_percent{device="md219"} 0
node_md_blocks_synced_percent{device="md3"} 0
node_md_blocks_synced_percent{device="md4"} 0
node_md_blocks_synced_percent{device="md6"} 8.5
node_md_blocks_synced_percent{device="md7"} 0
node_md_blocks_synced_percent{device="md8"} 8.5
node_md_blocks_synced_percent{device="md9"} 0
# HELP node_md_blocks_synced_speed current sync speed (in Kilobytes/sec)
# TYPE node_md_blocks_synced_speed gauge
node_md_blocks_synced_speed{device="md0"} 0
node_md_blocks_synced_speed{device="md00"} 0
node_md_blocks_synced_speed{device="md10"} 0
node_md_blocks_synced_speed{device="md101"} 0
node_md_blocks_synced_speed{device="md11"} 0
node_md_blocks_synced_speed{device="md12"} 0
node_md_blocks_synced_speed{device="md120"} 0
node_md_blocks_synced_speed{device="md126"} 0
node_md_blocks_synced_speed{device="md127"} 0
node_md_blocks_synced_speed{device="md201"} 114176
node_md_blocks_synced_speed{device="md219"} 0
node_md_blocks_synced_speed{device="md3"} 0
node_md_blocks_synced_speed{device="md4"} 0
node_md_blocks_synced_speed{device="md6"} 259783
node_md_blocks_synced_speed{device="md7"} 0
node_md_blocks_synced_speed{device="md8"} 259783
node_md_blocks_synced_speed{device="md9"} 0
# HELP node_md_disks Number of active/failed/spare disks of device.
# TYPE node_md_disks gauge
node_md_disks{device="md0",state="active"} 2
node_md_disks{device="md0",state="down"} 0
node_md_disks{device="md0",state="failed"} 0
node_md_disks{device="md0",state="spare"} 0
node_md_disks{device="md00",state="active"} 1
node_md_disks{device="md00",state="down"} 0
node_md_disks{device="md00",state="failed"} 0
node_md_disks{device="md00",state="spare"} 0
node_md_disks{device="md10",state="active"} 2
node_md_disks{device="md10",state="down"} 0
node_md_disks{device="md10",state="failed"} 0
node_md_disks{device="md10",state="spare"} 0
node_md_disks{device="md101",state="active"} 3
node_md_disks{device="md101",state="down"} 0
node_md_disks{device="md101",state="failed"} 0
node_md_disks{device="md101",state="spare"} 0
node_md_disks{device="md11",state="active"} 2
node_md_disks{device="md11",state="down"} 0
node_md_disks{device="md11",state="failed"} 1
node_md_disks{device="md11",state="spare"} 2
node_md_disks{device="md12",state="active"} 2
node_md_disks{device="md12",state="down"} 0
node_md_disks{device="md12",state="failed"} 0
node_md_disks{device="md12",state="spare"} 0
node_md_disks{device="md120",state="active"} 2
node_md_disks{device="md120",state="down"} 0
node_md_disks{device="md120",state="failed"} 0
node_md_disks{device="md120",state="spare"} 0
node_md_disks{device="md126",state="active"} 2
node_md_disks{device="md126",state="down"} 0
node_md_disks{device="md126",state="failed"} 0
node_md_disks{device="md126",state="spare"} 0
node_md_disks{device="md127",state="active"} 2
node_md_disks{device="md127",state="down"} 0
node_md_disks{device="md127",state="failed"} 0
node_md_disks{device="md127",state="spare"} 0
node_md_disks{device="md201",state="active"} 2
node_md_disks{device="md201",state="down"} 0
node_md_disks{device="md201",state="failed"} 0
node_md_disks{device="md201",state="spare"} 0
node_md_disks{device="md219",state="active"} 0
node_md_disks{device="md219",state="down"} 0
node_md_disks{device="md219",state="failed"} 0
node_md_disks{device="md219",state="spare"} 3
node_md_disks{device="md3",state="active"} 8
node_md_disks{device="md3",state="down"} 0
node_md_disks{device="md3",state="failed"} 0
node_md_disks{device="md3",state="spare"} 2
node_md_disks{device="md4",state="active"} 0
node_md_disks{device="md4",state="down"} 0
node_md_disks{device="md4",state="failed"} 1
node_md_disks{device="md4",state="spare"} 1
node_md_disks{device="md6",state="active"} 1
node_md_disks{device="md6",state="down"} 1
node_md_disks{device="md6",state="failed"} 1
node_md_disks{device="md6",state="spare"} 1
node_md_disks{device="md7",state="active"} 3
node_md_disks{device="md7",state="down"} 1
node_md_disks{device="md7",state="failed"} 1
node_md_disks{device="md7",state="spare"} 0
node_md_disks{device="md8",state="active"} 2
node_md_disks{device="md8",state="down"} 0
node_md_disks{device="md8",state="failed"} 0
node_md_disks{device="md8",state="spare"} 2
node_md_disks{device="md9",state="active"} 4
node_md_disks{device="md9",state="down"} 0
node_md_disks{device="md9",state="failed"} 2
node_md_disks{device="md9",state="spare"} 1
# HELP node_md_disks_required Total number of disks of device.
Expand Down Expand Up @@ -1740,6 +1795,25 @@ node_md_state{device="md9",state="check"} 0
node_md_state{device="md9",state="inactive"} 0
node_md_state{device="md9",state="recovering"} 0
node_md_state{device="md9",state="resync"} 1
# HELP node_md_sync_time_remaining_seconds Estimated finishing time for current sync in seconds.
# TYPE node_md_sync_time_remaining_seconds gauge
node_md_sync_time_remaining_seconds{device="md0"} 0
node_md_sync_time_remaining_seconds{device="md00"} 0
node_md_sync_time_remaining_seconds{device="md10"} 0
node_md_sync_time_remaining_seconds{device="md101"} 0
node_md_sync_time_remaining_seconds{device="md11"} 0
node_md_sync_time_remaining_seconds{device="md12"} 0
node_md_sync_time_remaining_seconds{device="md120"} 0
node_md_sync_time_remaining_seconds{device="md126"} 0
node_md_sync_time_remaining_seconds{device="md127"} 0
node_md_sync_time_remaining_seconds{device="md201"} 12
node_md_sync_time_remaining_seconds{device="md219"} 0
node_md_sync_time_remaining_seconds{device="md3"} 0
node_md_sync_time_remaining_seconds{device="md4"} 0
node_md_sync_time_remaining_seconds{device="md6"} 1020
node_md_sync_time_remaining_seconds{device="md7"} 0
node_md_sync_time_remaining_seconds{device="md8"} 1020
node_md_sync_time_remaining_seconds{device="md9"} 0
# HELP node_memory_Active_anon_bytes Memory information field Active_anon_bytes.
# TYPE node_memory_Active_anon_bytes gauge
node_memory_Active_anon_bytes 2.068484096e+09
Expand Down
45 changes: 44 additions & 1 deletion collector/mdadm_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,24 @@ var (
[]string{"device"},
nil,
)
blocksSyncedPctDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, "md", "blocks_synced_percent"),
"Percentage of blocks synced on device.",
[]string{"device"},
nil,
)
syncTimeRemainingDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, "md", "sync_time_remaining_seconds"),
"Estimated finishing time for current sync in seconds.",
[]string{"device"},
nil,
)
blockSyncedSpeedDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, "md", "blocks_synced_speed"),
"current sync speed (in Kilobytes/sec)",
[]string{"device"},
nil,
)
Comment on lines +123 to +128
Copy link
Member

@SuperQ SuperQ May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem necessary, we should be able to compute this from something like rate(node_md_blocks_synced[1m]) * <blocksize>.

Suggested change
blockSyncedSpeedDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, "md", "blocks_synced_speed"),
"current sync speed (in Kilobytes/sec)",
[]string{"device"},
nil,
)

Copy link
Author

@Finomosec Finomosec May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is usefull. It is the CURRENT speed, as it is shown in /stat/proc/mdstat
I have it showing in my Grafana board.
Plus i guess <blocksize> is not included in the data, so it would require additional configuration for each md-device.

Copy link
Author

@Finomosec Finomosec May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Grafana Board: https://grafana.com/grafana/dashboards/20989-node-exporter-mdadm-status/

Copy link
Contributor

@dswarbrick dswarbrick May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the groundwork has already been laid for #1085, and we probably should not add any new parsing functionality relating to /proc/mdstat.

)

func (c *mdadmCollector) Update(ch chan<- prometheus.Metric) error {
Expand Down Expand Up @@ -131,7 +149,13 @@ func (c *mdadmCollector) Update(ch chan<- prometheus.Metric) error {
float64(mdStat.DisksTotal),
mdStat.Name,
)

ch <- prometheus.MustNewConstMetric(
disksDesc,
prometheus.GaugeValue,
float64(mdStat.DisksDown),
mdStat.Name,
"down",
)
ch <- prometheus.MustNewConstMetric(
disksDesc,
prometheus.GaugeValue,
Expand Down Expand Up @@ -200,6 +224,25 @@ func (c *mdadmCollector) Update(ch chan<- prometheus.Metric) error {
float64(mdStat.BlocksSynced),
mdStat.Name,
)
ch <- prometheus.MustNewConstMetric(
blocksSyncedPctDesc,
prometheus.GaugeValue,
float64(mdStat.BlocksSyncedPct),
mdStat.Name,
)
ch <- prometheus.MustNewConstMetric(
syncTimeRemainingDesc,
prometheus.GaugeValue,
float64(mdStat.BlocksSyncedFinishTime*60),
mdStat.Name,
)
ch <- prometheus.MustNewConstMetric(
blockSyncedSpeedDesc,
prometheus.GaugeValue,
float64(mdStat.BlocksSyncedSpeed),
mdStat.Name,
)

}

return nil
Expand Down