Skip to content

Conversation

@myspotontheweb
Copy link

Updated the OTLP metrics endpoint for OpenTelemetry configuration.

The specification states that the OTEL_EXPORTER_OTLP_ENDPOINT is used as a base URL and that metrics path "/v1/metrics" will be appended.

Signed-off-by: Mark O'Connor [email protected]

Updated the OTLP metrics endpoint for OpenTelemetry configuration.

The specification states that the OTEL_EXPORTER_OTLP_ENDPOINT is used as a base URL and that metrics path "/v1/metrics" will be appended.

Signed-off-by: Mark O'Connor <[email protected]>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One nit only.


Note:

* The [OpenTelemtry specification](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.50.0/specification/protocol/exporter.md#endpoint-urls-for-otlphttp) states that the OTEL_EXPORTER_OTLP_METRICS_ENDPOINT env var must be used as a base URL. The signal ```/v1/metrics``` is automatically appended
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The [OpenTelemtry specification](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.50.0/specification/protocol/exporter.md#endpoint-urls-for-otlphttp) states that the OTEL_EXPORTER_OTLP_METRICS_ENDPOINT env var must be used as a base URL. The signal ```/v1/metrics``` is automatically appended
* The [OpenTelemtry specification](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.50.0/specification/protocol/exporter.md#endpoint-urls-for-otlphttp) states that the OTEL_EXPORTER_OTLP_METRICS_ENDPOINT env var must be used as a base URL. The signal `/v1/metrics` is automatically appended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants