Skip to content

Conversation

@ywwg
Copy link
Member

@ywwg ywwg commented Oct 2, 2025

@ywwg ywwg force-pushed the owilliams/utf8-abnf branch from 755a40d to 908e3a6 Compare October 2, 2025 15:33
@ywwg ywwg marked this pull request as ready for review October 2, 2025 15:34
@ywwg ywwg marked this pull request as draft October 2, 2025 15:37
@ywwg ywwg marked this pull request as ready for review October 2, 2025 15:41
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one nit comment

Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, I think need some examples with CI check on them

@ywwg ywwg requested a review from krajorama October 6, 2025 17:18
@krajorama
Copy link
Member

@ywwg I'd suggest to scan the "Design considerations" section, in particular https://prometheus.io/docs/specs/om/open_metrics_spec/#metric-naming-and-namespaces .

I've done it as a follow-up to relaxed suffix rules, see #2751

@ywwg ywwg requested review from dashpole and krajorama October 8, 2025 15:44
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for extending!

I assume we will follow with same/similar wording in 2.0, right?

Can we outline e.g. in the description of this PR why we add UTF-8 capability to 1.1 instead of releasing this change with 2.0? Would be useful for bookkeeping.

@ywwg
Copy link
Member Author

ywwg commented Oct 29, 2025

we are going to go directly to 2.0 and skip 1.1 after all, so I'll adapt this change to 2.0 instead

@ywwg
Copy link
Member Author

ywwg commented Oct 29, 2025

(I am not deleting 1.1 because we need to port some more changes from it into 2.0 and it's useful to keep it around for now)

@ywwg ywwg changed the title Update OM1.1 for UTF-8 metric names and labels Update OM2.0 for UTF-8 metric names and labels Oct 29, 2025
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix CI fail

@ywwg
Copy link
Member Author

ywwg commented Oct 30, 2025

removed diffs with 1.1 and cleaned things up a bit

@ywwg ywwg requested review from dashpole and krajorama October 30, 2025 14:57
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I really think we should add some examples that are checked against the ABNF. It's ok if you want to do it in a next PR as well.

@ywwg
Copy link
Member Author

ywwg commented Oct 31, 2025

Yeah can we do that in a followup? I'll file an issue

@ywwg
Copy link
Member Author

ywwg commented Oct 31, 2025

#2766

@ywwg ywwg force-pushed the owilliams/utf8-abnf branch from 50a5023 to ea1e18c Compare November 4, 2025 07:23
@ywwg ywwg requested a review from krajorama November 4, 2025 07:23
@krajorama krajorama merged commit 65a6ca0 into main Nov 5, 2025
6 checks passed
@krajorama krajorama deleted the owilliams/utf8-abnf branch November 5, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants