Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for prometheus/prometheus#8932. After think about the issue, my solution is divide into two steps.
My concern is that, firstly as the openMetricsParser is located in github.com/prometheus/prometheus/ , there may be some hidden circular import problem, although i have tested it works. Secondly, I may be totally wrong about the right direction for solving this issue. i'm very happy to hear from any advices:)!