-
Notifications
You must be signed in to change notification settings - Fork 821
Builder.withoutExemplars() setting cannot be overridden via properties #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3444294
to
3e792c9
Compare
@zeitlinger Somehow the build is not starting. Is there something else I need to do? |
no - that needs to be approved |
@cruftex the code is not formatted correctly - run |
Head branch was pushed to by a user without write access
@zeitlinger sorry... done! |
now there's a checkstyle issue [WARN] /home/runner/work/client_java/client_java/prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/Summary.java:52:5: Distance between variable 'exemplarsEnabled' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). [VariableDeclarationUsageDistance] |
…overridden via properties. Introduce builder for PrometheusProperties for testing. Minimal housekeeping, removing the redundant boolean flag. Signed-off-by: Jens Wilke <[email protected]>
Head branch was pushed to by a user without write access
I agree with checkstyle. Corrected. |
@zeitlinger ping |
The PR will fix the behaviour that exemplar support can be switched on via the properties, although it was disabled explicitly in the code definition by
withoutExemplars
. Currently this would enable exemplars:In TDD fashion I will add failing tests first.