chore(ci): Add yaml and action formatter/linter to CI#1899
Draft
kakkoyun wants to merge 6 commits intoprometheus:mainfrom
Draft
chore(ci): Add yaml and action formatter/linter to CI#1899kakkoyun wants to merge 6 commits intoprometheus:mainfrom
kakkoyun wants to merge 6 commits intoprometheus:mainfrom
Conversation
SuperQ
reviewed
Oct 25, 2025
Member
SuperQ
left a comment
There was a problem hiding this comment.
I would copy the .yamllint config from prometheus/prometheus.
SuperQ
reviewed
Oct 25, 2025
b082405 to
e6d8472
Compare
…nation Add two new Makefile targets to detect and fix carriage return (CRLF) line endings that can contaminate the codebase from Windows environments: - check-crlf: Scans all text files (excluding hidden dirs and vendor) for CRLF line endings and fails if any are found - fix-crlf: Automatically converts CRLF to LF using the tr command Add CRLF check to CI workflow to catch line ending issues early in PRs. The check runs immediately after checkout, before any other validation. Also rename go.yml to validate.yml to better reflect the workflow's purpose, and fix job name casing (supportedVersions -> supported_versions). Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
e6d8472 to
431ed50
Compare
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
bwplotka
approved these changes
Dec 2, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thank you!
I merged some PR that upgrades some versions, so you need to rebase, sorry 🙃
LGTM, modulo "#magic___^_^___line", what's that?
| **Do you mind updating us on the status?** Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗 | ||
|
|
||
| If there will be no activity in the next 2 weeks, this issue will be closed (we can always reopen a PR if you get back to this!). | ||
| Hello 👋 Looks like there was no activity on this amazing PR for the last 60 days. **Do you mind updating us on the status?** Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗 #magic___^_^___line If there will be no activity in the next 2 weeks, this issue will be closed (we can always reopen a PR if you get back to this!). |
Member
There was a problem hiding this comment.
What's this #magic___^_^___line ? (:
Member
Author
There was a problem hiding this comment.
Probably, I did a weird search and replaced and forgot to revert the changes.
I'll fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.