Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
kakkoyun
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution.
However CI fails, so it needs some more work.
|
When we are at it maybe we should add GOARCH as well. Now that GitHub actions have the arm64 machines. |
|
I also worked on this ticket 2 weeks ago but I didn't fix all: diff link. I managed to conditionally enable CGO based on need, but I'm still running into test failures on Windows. I'd really appreciate any pointers on how to get those passing. Since you also opened a PR on this topic, maybe you’ll find some ideas or inspiration from my approach too! |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
From the KubeCon ContribFest 👋
This PR added GOOS as variable to the go test CI
Fix #1761
Please check @ArthurSens