Fixed condition, when local dns lookup should happen. #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulikl
force-pushed
the
fix-SkipResolvePhaseWithProxy
branch
from
b94daf7 to
0412f5a
Compare
Bug was introduced with option proy_from_enviroment with release V0.24. Signed-off-by: Ulrike Klusik <[email protected]>
ulikl
force-pushed
the
fix-SkipResolvePhaseWithProxy
branch
from
0412f5a to
54ea96b
Compare
| @@ -328,7 +328,7 @@ func ProbeHTTP(ctx context.Context, target string, module config.Module, registr | |||
| targetPort := targetURL.Port() | |||
|
|
|||
| var ip *net.IPAddr | |||
| if !module.HTTP.SkipResolvePhaseWithProxy || module.HTTP.HTTPClientConfig.ProxyConfig.ProxyURL.URL == nil || module.HTTP.HTTPClientConfig.ProxyConfig.ProxyFromEnvironment { | |||
| if !module.HTTP.SkipResolvePhaseWithProxy || (module.HTTP.HTTPClientConfig.ProxyConfig.ProxyURL.URL == nil && !module.HTTP.HTTPClientConfig.ProxyConfig.ProxyFromEnvironment) { | |||
There was a problem hiding this comment.
can you add a test to reproduce issue #1154 and show that this change in logic fixes that??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was introduced with option proxy_from_enviroment with release V0.24.
fixes Issue #1154