Associator buildLabelsMap to lower case EndpointName to match ARN #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // endpoint name value to be able to match the resource ARN | ||
| if cwMetric.Namespace == "AWS/SageMaker" && name == "EndpointName" { | ||
| if awsSageMakerEndpointUpper.MatchString(value) { | ||
| value = strings.ToLower(value) |
There was a problem hiding this comment.
Wondering if we can always just convert to lowercase without the regex match?
There was a problem hiding this comment.
To be honest I added it last minute to match the AmazonMQ one. I thought it would be more efficient to just convert to lowercase when needed but after some tests it is more efficient to just run the conversion every time.
I'll remove that check asap.
There was a problem hiding this comment.
Regex has been removed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #1163. The problem we are facing is that when the matching resource is being looked up, the associator is not finding it. The signature is calculated using the ARN endpoint name through the regex, but the ARN endpoint name is in lower case. If the endpoint name contains any upper case characters it fails as the signature value is different from the ARN one due to casing.
So, in order to fix it if the metric is from sagemaker and it uses the endpoint name, if it contains any upper case character it converts the endpoint name to lower case to calculate the signature.
In the issue some example is provided, hopefully this way it can be fixed.