Skip to content

Conversation

@Rawi01
Copy link
Collaborator

@Rawi01 Rawi01 commented Apr 2, 2023

This PR fixes #3389

I also updated delombok to return 1 if there is an error and updated the action to run the test during the build.

@victorwss
Copy link
Contributor

victorwss commented Nov 12, 2024

I had a problem in a project with some multi-release module JARs as dependencies. My project uses lombok and delombok goes nuts due to this bug, even if using the latest edge version. So, I manually applied your patch to Delombok.java into lombok's edge, recompiled lombok and added it to my project. Worked like a charm! For me, this should be included in next version!

@victorwss
Copy link
Contributor

@Rawi01 Any reason why this was still not integrated? It is a great work.

@Rawi01 Rawi01 force-pushed the delombok-multirelease branch from 1235380 to 5a19894 Compare August 27, 2025 20:51
@reneleonhardt
Copy link

It's sad when contributors fixing old bugs are not even being appreciated for their efforts with a review... 😞

@rzwitserloot
Copy link
Collaborator

@reneleonhardt You should like into how the XZ hack went down. It's entitled meanspirited whiners like you that hurt open source. You. You hurt open source. Cut it out.

Final notice, next complaint will get you banned from this project.

@rzwitserloot rzwitserloot added this to the next-next-version milestone Sep 4, 2025
@rzwitserloot rzwitserloot modified the milestones: v1.18.42, next-version Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Delombok fails to resolve module name of multi-release jar

4 participants