Split ReplicationChannel into ServerChannel and ClientChannel
#490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
==========================================
+ Coverage 81.18% 81.70% +0.52%
==========================================
Files 52 52
Lines 2992 2996 +4
==========================================
+ Hits 2429 2448 +19
+ Misses 563 548 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For clarity. While doing so, I noticed that we register an extra client channel. While the server requires two channels, the client only needs one. I also removed wrong comment about receive functions. They aren't called by backends.
UkoeHB
reviewed
May 21, 2025
| /// | ||
| /// <div class="warning"> | ||
| /// | ||
| /// Should only be called from the messaging backend. |
There was a problem hiding this comment.
It's not called by messaging backends. It's called by Replicon to read the messages. Maybe I should even make it private 🤔
There was a problem hiding this comment.
Yeah make it private if it's not for the public or backend APIs.
| /// | ||
| /// <div class="warning"> | ||
| /// | ||
| /// Should only be called from the messaging backend. |
I had to reorganize test since integration tests don't have access to private methods.
UkoeHB
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clarity. While doing so, I noticed that we register an extra client channel. While the server requires two channels, the client only needs one, the client only needs one for the acks.
Based on #488 to avoid too many conflicts.