Skip to content

Release all affected crates in workspace #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2025

Conversation

alerque
Copy link
Collaborator

@alerque alerque commented May 21, 2025

Closes #381

Follow up on #382 that I merged early before these version bumps to get CI tests and lints working as expected while we touch up #373.

@alerque alerque force-pushed the tag-releases branch 2 times, most recently from 70566fe to 9329008 Compare May 22, 2025 13:21
@alerque alerque merged commit f22da4e into projectfluent:main May 22, 2025
6 checks passed
@alerque alerque deleted the tag-releases branch May 22, 2025 13:37
@cschramm
Copy link

At least the changed dependency on fluent-bundle is a breaking change for fluent, so that it should become 0.17. 0.16.2 e.g. breaks i18n-embed.

@alerque
Copy link
Collaborator Author

alerque commented May 22, 2025

@cschramm Please open a new issue if you feel there is something that needs correcting. I don't see why you think that though — if all you use is fluent the API surface did not change at all. If you use the underlying fluent-bundle directly at all, that did change a little, hence the version bump scheme we used. Also note that I already tested i18n-embed and even submitted a PR upstream related to these bumps and did not see a problem with it. If you have more specifics of your issue please open a fresh issue. Thanks.

@ids1024
Copy link

ids1024 commented May 22, 2025

It seems fluent_bundle is a "public dependency" of fluent. So a semver bump in fluent_bundle should require a semver bump in fluent.

The result of this is that projects depending on fluent and i18n-embed are getting errors about incompatible types (from different versions of fluent-syntax) when running cargo update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please release a new version of fluent-bundle
5 participants