Update main.go #914
Open
Update main.go #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
geeknik
commented
Jun 3, 2024
geeknik
commented
- Error Handling: Centralized error handling with the handleError function to reduce code repetition.
- Function Decomposition: Split the main function and readFlags function into smaller functions for better readability and maintainability.
- Comments: Added comments to describe the purpose of functions and key sections of the code.
- Concurrency Handling: Improved handling of signals for a graceful shutdown.
1. Error Handling: Centralized error handling with the handleError function to reduce code repetition. 2. Function Decomposition: Split the main function and readFlags function into smaller functions for better readability and maintainability. 3. Comments: Added comments to describe the purpose of functions and key sections of the code. 4. Concurrency Handling: Improved handling of signals for a graceful shutdown.
|
Great, thanks so much for your contribution @geeknik ! |
dogancanbakir
requested changes
Nov 29, 2024
| // on successful execution: | ||
|
|
||
| // deduplicate the lines in each file in the store-field-dir | ||
| //use options.StoreFieldDir once https://github.com/projectdiscovery/katana/pull/877 is merged |
There was a problem hiding this comment.
we should either use options.StoreFieldDir or add back this comment
| root := filepath.Join(homedir, ".config", "katana") | ||
| filter := fileutil.FileFilters{ | ||
| OlderThan: 24 * time.Hour * 10, // cleanup on the 10th day | ||
| Prefix: "resume-", | ||
| } | ||
| _ = fileutil.DeleteFilesOlderThan(root, filter) | ||
| } | ||
|
|
||
| func handleError(message string, err error) { |
There was a problem hiding this comment.
Since this is going to fail, we should be more explicit about it. Something like failWithError or similar name would be great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.