Refactor internal/envoy/v3 package functions #6871
Open
+579
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take two of projectcontour#5523 That introduces a struct `NewEnvoysGen` that allows us to modify the behaviour of Envoy config generation. This will help with projectcontour#6806 On the debate on `singleton` vs `struct` approach. I thought this again and I realized that `struct` is probably worth the big diff here. For the following reason: * It allows us to test the behaviour much easier. With a singleton it would be impossible for higher level tests like tests in `internal/featuretests` to modify the behaviour of the Envoy config generation. With a struct, we can just pass the config options to the struct and test the behaviour. Signed-off-by: Sotiris Nanopoulos <[email protected]>
davinci26
requested review from
skriss and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
rajatvig and
wilsonwu
and removed request for
a team
|
(waiting for the CI to pass before I give people the go ahead to review) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6871 +/- ##
==========================================
+ Coverage 81.05% 81.08% +0.03%
==========================================
Files 133 134 +1
Lines 20026 20100 +74
==========================================
+ Hits 16232 16299 +67
- Misses 3500 3507 +7
Partials 294 294
|
Signed-off-by: Sotiris Nanopoulos <[email protected]>
|
@sunjayBhatia this is ready for review. Does this need a release note? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two of #5523
That introduces a struct
NewEnvoysGenthat allows us to modify the behaviour of Envoy config generation. This will help with#6806
On the debate on
singletonvsstructapproach. I thought this again and I realized thatstructis probably worth the big diff here. For the following reason:internal/featureteststo modify the behaviour of the Envoy config generation. With a struct, we can just pass the config options to the struct and test the behaviour.