Skip to content

Implement matrix assembly and factorization persistent through entire simulation #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jibril-b-coulibaly
Copy link
Contributor

Assemble and factorize direct solver matrices only once at the beginning of the first step

corresponding issue: #566

@rserban
Copy link
Member

rserban commented Apr 18, 2025

I strongly suggest you ask us first before starting work on a new PR.
In particular, this type of feature has been on my todo list for a while and I intend to implement it in the near future. Having said that, I will implement something more robust and general than what you proposed, where the Jacobian is evaluated and factorized when needed and reused over multiple steps as long as it's still appropriate.

@jibril-b-coulibaly
Copy link
Contributor Author

@rserban as I clarified in #566 , this is something I discussed with @tasora @dariofusai93 @dariomangoni .

I thought they might be in charge of triage for this PR/issue, and that maybe you had talked about it without me as well.

Let's find a way forward together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants