-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MIGENG-455 Kie session 'dedicated' to Complexity.drl (#50)
* MIGENG-455 Kie session 'dedicated' to Complexity.drl * Fix assertion for packages not found Co-Authored-By: Carlos E. Feria Vila <[email protected]> Co-authored-by: Carlos E. Feria Vila <[email protected]>
- Loading branch information
1 parent
9d0539d
commit 7f0b657
Showing
9 changed files
with
214 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...rces/org/jboss/xavier/analytics/rules/agendafocus/complexity/AgendaFocusForComplexity.drl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package org.jboss.xavier.analytics.rules.agendafocus.complexity; | ||
| import java.lang.String; | ||
| import org.jboss.xavier.analytics.pojo.output.workload.inventory.WorkloadInventoryReportModel | ||
| dialect "java" | ||
|
|
||
| agenda-group "MAIN" | ||
|
|
||
| rule "AgendaFocusForComplexity" | ||
| when | ||
| workloadInventoryReport : WorkloadInventoryReportModel() | ||
| then | ||
| kcontext.getKieRuntime().getAgenda().getAgendaGroup("Complexity").setFocus(); | ||
| end |
2 changes: 1 addition & 1 deletion
2
...s/rules/workload/inventory/Complexity.drl → ...kload/inventory/complexity/Complexity.drl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...inventory/GetWorkloadInventoryReports.drl → ...y/queries/GetWorkloadInventoryReports.drl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
150 changes: 150 additions & 0 deletions
150
.../org/jboss/xavier/analytics/rules/workload/inventory/WorkloadInventoryComplexityTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| package org.jboss.xavier.analytics.rules.workload.inventory; | ||
|
|
||
| import org.jboss.xavier.analytics.pojo.output.workload.inventory.WorkloadInventoryReportModel; | ||
| import org.jboss.xavier.analytics.rules.BaseIntegrationTest; | ||
| import org.jboss.xavier.analytics.test.Utils; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
| import org.kie.api.runtime.rule.QueryResults; | ||
| import org.kie.api.runtime.rule.QueryResultsRow; | ||
|
|
||
| import java.text.ParseException; | ||
| import java.text.SimpleDateFormat; | ||
| import java.util.Arrays; | ||
| import java.util.Collection; | ||
| import java.util.Collections; | ||
| import java.util.HashMap; | ||
| import java.util.HashSet; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| import static org.hamcrest.CoreMatchers.instanceOf; | ||
| import static org.junit.Assert.*; | ||
|
|
||
| @RunWith(Parameterized.class) | ||
| public class WorkloadInventoryComplexityTest extends BaseIntegrationTest { | ||
|
|
||
| @Parameterized.Parameters(name = "{index}: Test OS name {0} for rule {1}") | ||
| public static Collection<Object[]> data() { | ||
| return Arrays.asList(new Object[][]{ | ||
| {"SUSE Linux Enterprise 12 (64-bit)", "No_Flag_Supported_OS", null, WorkloadInventoryReportModel.COMPLEXITY_EASY}, | ||
| {"Oracle Linux 6 (64-bit)", "No_Flag_Convertible_OS", null, WorkloadInventoryReportModel.COMPLEXITY_MEDIUM}, | ||
| {"Red Hat Enterprise Linux 5 (64-bit)", "One_Flag_Supported_OS", Collections.singleton(WorkloadInventoryReportModel.SHARED_DISK_FLAG_NAME), WorkloadInventoryReportModel.COMPLEXITY_MEDIUM}, | ||
| {"CentOS 7 (64-bit)", "One_Or_More_Flags_Convertible_OS", new HashSet<>(Arrays.asList(WorkloadInventoryReportModel.SHARED_DISK_FLAG_NAME, WorkloadInventoryReportModel.MORE_THAN_4_NICS_FLAG_NAME)), WorkloadInventoryReportModel.COMPLEXITY_HARD}, | ||
| {"Microsoft Windows 7 (64-bit)", "More_Than_One_Flag_Supported_OS", new HashSet<>(Arrays.asList(WorkloadInventoryReportModel.MORE_THAN_4_NICS_FLAG_NAME, WorkloadInventoryReportModel.RDM_DISK_FLAG_NAME)), WorkloadInventoryReportModel.COMPLEXITY_HARD}, | ||
| {"Microsoft Windows XP Professional (32-bit)", "No_Flags_Not_Supported_OS", null, WorkloadInventoryReportModel.COMPLEXITY_UNSUPPORTED}, | ||
| {"Ubuntu", "One_Or_More_Flags_Not_Supported_OS", Collections.singleton(WorkloadInventoryReportModel.RDM_DISK_FLAG_NAME), WorkloadInventoryReportModel.COMPLEXITY_UNSUPPORTED}, | ||
| {"", "Not_Detected_OS", new HashSet<>(Arrays.asList(WorkloadInventoryReportModel.SHARED_DISK_FLAG_NAME, WorkloadInventoryReportModel.MORE_THAN_4_NICS_FLAG_NAME)), WorkloadInventoryReportModel.COMPLEXITY_UNKNOWN}, | ||
| }); | ||
| } | ||
|
|
||
| @Parameterized.Parameter | ||
| public String os; | ||
|
|
||
| @Parameterized.Parameter(1) | ||
| public String ruleExpected; | ||
|
|
||
| @Parameterized.Parameter(2) | ||
| public Set<String> flags; | ||
|
|
||
| @Parameterized.Parameter(3) | ||
| public String complexityExpected; | ||
|
|
||
| public WorkloadInventoryComplexityTest() | ||
| { | ||
| super("WorkloadInventoryComplexityKSession0", "org.jboss.xavier.analytics.rules.*", 10); | ||
| } | ||
|
|
||
| private static WorkloadInventoryReportModel generateWorkloadInventoryReportModel() throws ParseException | ||
| { | ||
| //Basic Fields | ||
| final WorkloadInventoryReportModel workloadInventoryReportModel = new WorkloadInventoryReportModel(); | ||
| workloadInventoryReportModel.setProvider("IMS vCenter"); | ||
| workloadInventoryReportModel.setDatacenter("V2V-DC"); | ||
| workloadInventoryReportModel.setCluster("Cluster 1"); | ||
| workloadInventoryReportModel.setVmName("vm tests"); | ||
| workloadInventoryReportModel.setDiskSpace(100000001L); | ||
| workloadInventoryReportModel.setMemory(4096L); | ||
| workloadInventoryReportModel.setCpuCores(4); | ||
| workloadInventoryReportModel.setProduct("VMware vCenter"); | ||
| workloadInventoryReportModel.setVersion("6.5"); | ||
| workloadInventoryReportModel.setHost_name("esx13.v2v.bos.redhat.com"); | ||
| workloadInventoryReportModel.setCreationDate(new SimpleDateFormat("yyyy-M-dd'T'hh:mm:ss.S").parse("2019-09-18T14:52:45.871Z")); | ||
| workloadInventoryReportModel.setComplexity(WorkloadInventoryReportModel.COMPLEXITY_EASY); | ||
| workloadInventoryReportModel.setSsaEnabled(true); | ||
| // Targets | ||
| workloadInventoryReportModel.setRecommendedTargetsIMS(new HashSet<>(Arrays.asList("RHV", "OSP"))); | ||
| return workloadInventoryReportModel; | ||
| } | ||
|
|
||
| private static void checkUnchangedFields(WorkloadInventoryReportModel workloadInventoryReportModel) throws ParseException | ||
| { | ||
| // Check that the object has exactly the fields that the rule tested should NOT add/change | ||
| // BasicFields | ||
| assertEquals("IMS vCenter",workloadInventoryReportModel.getProvider()); | ||
| assertEquals("V2V-DC",workloadInventoryReportModel.getDatacenter()); | ||
| assertEquals("Cluster 1",workloadInventoryReportModel.getCluster()); | ||
| assertEquals("vm tests",workloadInventoryReportModel.getVmName()); | ||
| assertEquals(100000001L,workloadInventoryReportModel.getDiskSpace(), 0); | ||
| assertEquals(4096,workloadInventoryReportModel.getMemory().intValue()); | ||
| assertEquals(4,workloadInventoryReportModel.getCpuCores().intValue()); | ||
| assertEquals("VMware vCenter", workloadInventoryReportModel.getProduct()); | ||
| assertEquals("6.5", workloadInventoryReportModel.getVersion()); | ||
| assertEquals("esx13.v2v.bos.redhat.com", workloadInventoryReportModel.getHost_name()); | ||
| assertEquals(new SimpleDateFormat("yyyy-M-dd'T'hh:mm:ss.S").parse("2019-09-18T14:52:45.871Z"), workloadInventoryReportModel.getCreationDate()); | ||
| // Targets | ||
| final Set<String> targets = workloadInventoryReportModel.getRecommendedTargetsIMS(); | ||
| assertNotNull(targets); | ||
| assertEquals(2, targets.size()); | ||
| Assert.assertTrue(targets.contains("RHV")); | ||
| Assert.assertTrue(targets.contains("OSP")); | ||
| // Workloads | ||
| Assert.assertTrue(workloadInventoryReportModel.getSsaEnabled()); | ||
| } | ||
|
|
||
| // Method with checks specific to this test cases: # of rules fired, agenda group focus rules name | ||
| private WorkloadInventoryReportModel checkResultAndGet(Map<String, Object> results) | ||
| { | ||
| // check that the number of rules fired is what you expect | ||
| assertEquals(2, results.get(NUMBER_OF_FIRED_RULE_KEY)); | ||
| // check the names of the rules fired are what you expect | ||
| Utils.verifyRulesFiredNames(this.agendaEventListener,"AgendaFocusForComplexity", ruleExpected); | ||
| // retrieve the QueryResults that was available in the working memory from the results | ||
| QueryResults queryResults= (QueryResults) results.get(QUERY_IDENTIFIER); | ||
| // Check that the number of object is the right one (in this case, there must be just one report) | ||
| assertEquals(1, queryResults.size()); | ||
| // Check that the object is of the expected type and with the expected identifier (i.e. "report") | ||
| QueryResultsRow queryResultsRow = queryResults.iterator().next(); | ||
| Assert.assertThat(queryResultsRow.get("report"), instanceOf(WorkloadInventoryReportModel.class)); | ||
| return (WorkloadInventoryReportModel) queryResultsRow.get("report"); | ||
| } | ||
|
|
||
| @Test | ||
| public void test() throws ParseException | ||
| { | ||
| WorkloadInventoryReportModel inputWorkloadInventoryReportModel = generateWorkloadInventoryReportModel(); | ||
| inputWorkloadInventoryReportModel.setOsDescription(os); | ||
| inputWorkloadInventoryReportModel.setFlagsIMS(flags); | ||
|
|
||
| Map<String, Object> facts = new HashMap<>(); | ||
| facts.put("workloadInventoryReportModel", inputWorkloadInventoryReportModel); | ||
|
|
||
| Map<String, Object> results = createAndExecuteCommandsAndGetResults(facts, "GetWorkloadInventoryReports"); | ||
| WorkloadInventoryReportModel workloadInventoryReportModel = checkResultAndGet(results); | ||
| checkUnchangedFields(workloadInventoryReportModel); | ||
| // BasicFields | ||
| assertEquals(os, workloadInventoryReportModel.getOsDescription()); | ||
| // Flags | ||
| final Set<String> flagsIMS = workloadInventoryReportModel.getFlagsIMS(); | ||
| if (flags != null) | ||
| { | ||
| assertNotNull(flagsIMS); | ||
| assertEquals(flags.size(), flagsIMS.size()); | ||
| assertTrue(flagsIMS.containsAll(flags)); | ||
| } | ||
| // Complexity | ||
| assertEquals(complexityExpected, workloadInventoryReportModel.getComplexity()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters