Skip to content

test(ec2): add SG probe/readback rst and refresh SG lifecycle docs#39

Open
audreyll2 wants to merge 8 commits into
project-vera:mainfrom
audreyll2:tests
Open

test(ec2): add SG probe/readback rst and refresh SG lifecycle docs#39
audreyll2 wants to merge 8 commits into
project-vera:mainfrom
audreyll2:tests

Conversation

@audreyll2

Copy link
Copy Markdown

.

@audreyll2 audreyll2 changed the title Merging unmerged commits after changing the title that accidentally remove one empty subbranch. test(ec2): add SG probe/readback rst and refresh SG lifecycle docs Mar 29, 2026
@archit-bhatnagar

Copy link
Copy Markdown
Contributor

Thanks for the work here, unfortunately this now conflicts with main in securitygroup.py and dhcpoptions.py, and most of the code changes have landed through other PRs: the SG parsing/describe-shape fixes came in via #48, and the DHCP options fixes (dopt- prefix, DhcpConfiguration.N parsing, response shape) via #49. So this needs a rebase, and after that, it should shrink a lot. What's still valuable:

  • the elasticnetworkinterface.py groupSet fix — please dedupe _serialize_group_set (it's defined twice) and revert the "\n".join → "".join changes in the three serializers, they diverge from the rest of the codebase
  • the lifecycle rst tests (test: add EC2 networking lifecycle and dependency rst examples #30 closed without merging, so these aren't in the tree yet)

Some cleanup with the rebase: there are five [sg-debug] print() calls left in securitygroup.py (one dumps the full XML on every DescribeSecurityGroups), a commented-out _normalize_ip_permissions block, and sg_probe.sh / sg_probe_output.txt / lifecyclePRmapping.md shouldn't live in tests/; the PR body is a better place for that context.

Also, FYI, CI now runs on PRs (CLI suite ≥79% + all 7 Terraform cases), so you'll get automatic verification when you push the rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants