[COST-6579] update payload csv file names to reflect content

[djnakabaale]

Jira Ticket

COST-6579

Description

This change updates the naming convention for csv report files packaged withing the operator's payload.

Testing instructions

Prerequisites:

• Access to an OpenShift cluster.
• A public Quay.io repository (or other container registry) to push the operator image.

1. Prepare the operator image

1. Checkout feature branch

2. Build and push the operator to your quay repo.Replace <USERNAME> with your Quay.io username and <TAG> with your desired image tag

   make docker-buildx IMG=quay.io/<USERNAME>/koku-metrics-operator:<TAG>

2. Deploy the operator to your OpenShift cluster

1. login into your cluster

2. create a koku-metrics-operator namespace

   oc new-project koku-metrics-operator

3. Pull the image to make sure its available on your machine

   docker pull quay.io/<USERNAME>/koku-metrics-operator:<TAG>

4. Deploy the operator

   make deploy IMG=quay.io/<USERNAME>/koku-metrics-operator:<TAG>

3. Configure metrics collection

1. Copy the yaml below to create a costmanagementmetricsconfig.yaml file

   apiVersion: costmanagement-metrics-cfg.openshift.io/v1beta1
   kind: CostManagementMetricsConfig
   metadata:
       name: costmanagementmetricscfg-sample-v1beta1
       namespace: koku-metrics-operator
   spec:
       upload:
           ingress_path: /api/ingress/v1/upload
           upload_toggle: false
           validate_cert: true
       packaging:
           max_reports_to_store: 30
           max_size_MB: 100
       api_url: 'https://console.redhat.com'
       prometheus_config:
           collect_previous_data: true
           disable_metrics_collection_cost_management: false
           disable_metrics_collection_resource_optimization: false
           service_address: 'https://thanos-querier.openshift-monitoring.svc:9091'
       authentication:
           type: token
       source:
           create_source: false
           name: ''

2. deploy the configuration

   oc apply -f costmanagementmetricsconfig.yaml

4. Verify setrics collection

1. Follow the instructions on downloading reports from the operator to retrieve a payload and inspect that the packaged reports reflect their contents. Here's an example payload: 20250717T162226_411808-cost-mgmt.tar.gz

Summary by Sourcery

Replace generic UID-based CSV report filenames with content-reflective names derived from the original file basenames and an index

Enhancements:

• Add createCSVUploadName helper to derive upload filenames from source CSV names with an index suffix.
• Update manifest generation and tarball packaging to use the new CSV naming helper instead of the UID-based pattern

Tests:

• Update packaging tests to expect the new content-based CSV naming convention.

[sourcery-ai]

Reviewer's Guide

The PR replaces a generic UID-based CSV naming scheme with a new helper that derives filenames from their source basename and index, updating both the packaging logic and tests to use this more descriptive convention.

Class diagram for FilePackager changes (CSV naming)

classDiagram
    class FilePackager {
        +getManifest(archiveFiles, filePath, cr)
        +writeTarball(tarFileName, manifestFileName, archiveFiles)
        +GetFileInfo(file string) (FileInfoManifest, error)
        +createCSVUploadName(filePath string, idx int) string
        -uid string
        -manifest manifestInfo
    }
    class manifestInfo {
        <<struct>>
        +costFiles []string
        +rosFiles []string
    }
    FilePackager --> manifestInfo : uses

Loading

File-Level Changes

Change	Details	Files
Introduce createCSVUploadName helper to build CSV filenames from source file names and index	Add createCSVUploadName method on FilePackager Extract base filename and remove its extension Format name as base..csv	internal/packaging/packaging.go
Refactor manifest generation and tarball writing to use the new naming helper	Replace p.uid-based name generation in getManifest loops Replace p.uid-based name generation in writeTarball loop Call createCSVUploadName with file path and index	internal/packaging/packaging.go
Update packaging tests to expect content-reflective CSV names	Change expected manifest loops to call createCSVUploadName Remove hard-coded UID-based filenames in tests Align test setup with new naming convention	internal/packaging/packaging_test.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (4275d33) to head (602cc26).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   83.13%   83.16%   +0.02%     
==========================================
  Files          16       16              
  Lines        3060     3065       +5     
==========================================
+ Hits         2544     2549       +5     
  Misses        431      431              
  Partials       85       85              

Flag	Coverage Δ
unittests	83.16% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/packaging/packaging.go	80.72% <100.00%> (+0.22%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4275d33...602cc26. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sourcery-ai]

Hey @djnakabaale - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[djnakabaale]

@sourcery-ai review

[sourcery-ai]

Hey @djnakabaale - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}