[COST-6562] - Rename ROS label

[lcouzens]

Insights is being renamed. To fall in-line with naming conventions we are proposing to remove insights from the name and keep the label generic enough that we wont need to do this again in the future if things are rebranded again.

This change keeps the old label and adds a new supported label to ROS queries. This means current customers don't need to change all there current deployments to the new label as the old label will still be supported.

Summary by Sourcery

Add support for a new generic label for resource optimization (cost_management_optimizations) across queries, controller messages, documentation, and tests while retaining backward compatibility with the existing insights_cost_management_optimizations label.

Enhancements:

• Update Prometheus queries to include an OR condition for both label_cost_management_optimizations='true' and label_insights_cost_management_optimizations='true'.
• Adjust controller status messages and logs to reference the new label name.
• Revise test expectations and sample data to validate the new label implementation.

Documentation:

• Update CLI usage instructions and examples in CSV manifests and documentation to use cost_management_optimizations='true'.
• Modify report fields and CSV description documents to reflect the new label naming.

Tests:

• Amend existing controller unit tests to expect messages referencing the new label.
• Refresh test data files for namespace filtering to include the new label.

[sourcery-ai]

Reviewer's Guide

This PR extends ROS metric collection by adding a new generic cost_management_optimizations label alongside the legacy insights_cost_management_optimizations label, preserves backward compatibility in queries, updates operator manifests and docs to reference the generic label, and adjusts controller logic and tests accordingly.

File-Level Changes

Change	Details	Files
Extended ROS Prometheus queries to support new generic label alongside legacy one	Modified namespace filter query to OR the old and new labels Updated each ros:* query to include both label filters	internal/collector/queries.go
Replaced user-facing occurrences of the old label with the new generic label	Updated CSV manifest CLI instructions to use cost_management_optimizations Revised markdown documentation to reference the generic label	bundle/manifests/koku-metrics-operator.clusterserviceversion.yaml docs/csv-description.md docs/report-fields-description.md
Updated controller logic and messages to reference the new label	Changed DataCollectionMessage to mention cost_management_optimizations Adjusted log.Info call for no enabled namespaces to use the new label	internal/controller/prometheus.go
Adjusted tests and fixtures to expect and handle the new label	Updated controller test assertions to look for cost_management_optimizations Replaced namespace-filter test fixture to include the new label	internal/controller/costmanagementmetricsconfig_controller_test.go internal/collector/test_files/test_data/ros-namespace-filter

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (7c701f6) to head (181f65d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files          16       16           
  Lines        3060     3060           
=======================================
  Hits         2544     2544           
  Misses        431      431           
  Partials       85       85           

Flag	Coverage Δ
unittests	83.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/controller/prometheus.go	93.75% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c701f6...181f65d. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sourcery-ai]

Hey @lcouzens - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[djnakabaale]

I think this is looking good overall. I left a few minor comments:

[djnakabaale]

suggestion: we can clarify the operator versions where the different labels are supported. This is mostly to carter for users on older versions of the operator.
For example label_cost_management_optimizations label will only be supported in version v4.1.0 and going forward.

[lcouzens]

See if thats any better.

[djnakabaale]

👍🏾 yes, that's better. thanks for addressing it!