Skip to content

Update dependency golangci/golangci-lint to v2.13.1 - #1445

Open
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/golangci-golangci-lint-2.x
Open

Update dependency golangci/golangci-lint to v2.13.1#1445
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/golangci-golangci-lint-2.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change Pending
golangci/golangci-lint uses-with minor v2.12.2v2.13.1 v2.13.2

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v2.13.1

Compare Source

Released on 2026-08-20

  1. Linters bug fixes
    • ginkgolinter: from 0.23.1 to 0.24.0
    • gofmt: from d62b90e to e84e050
    • staticcheck: from 0.8.0-rc.1 to 0.8.0
    • wsl_v5: from 5.8.0 to 5.9.0

v2.13.0

Compare Source

Released on 2026-08-19

  1. Enhancements
    • 🎉 go1.27 support
  2. Bug fixes
    • fix: cache package facts
  3. Linters new features or changes
    • dupword: from 0.1.7 to 0.1.8 (new option skip-raw-strings)
    • errcheck: from 1.10.0 to 1.20.0
    • exhaustruct_v5: from 4.0.0 to 5.0.2 (new configuration)
    • exhaustruct: deprecated and replaced by exhaustruct_v5
    • fatcontext: from 0.9.0 to 0.10.0 (new options: check-loops, check-function-literals)
    • goconst: from 1.10.0 to 1.11.0 (new options: ignore-map-keys, exclude-types)
    • gofumpt: from 0.9.2 to 0.11.0 (new options: extra.group-params, extra.clothe-returns, extra.balance-calls)
    • gomoddirectives: from 0.8.0 to 0.9.0 (new option: replace-allow-all)
    • gosec: from 2.26.1 to 2.27.1
    • govet-modernize: from 0.44.0 to 0.49.0 (fmtappendf is removed. New analyzers atomictypes, embedlit, errorsastype, importcomment, reflecttypeassert, slicesclip, and slicesbackward. waitgroup is renamed waitgroupgo)
    • iface: from 1.4.3 to 1.5.0 (new analyzer: unusedmethod)
    • noinlineerr: from 1.0.5 to 1.0.6
    • nonamedreturns: from 1.0.6 to 1.0.8 (new option: allow-unused-named-returns)
    • recvcheck: from 0.2.0 to 0.3.0 (new default exclusions)
    • unparam: from 5beb8c8 to 3f964bc
  4. Linters bug fixes
    • clickhouse-go-linter: from 1.2.0 to 1.2.1
    • errname: from 1.1.1 to 1.1.2
    • exhaustruct: from 5.0.2 to 5.0.3
    • funcorder: add missing Function field
    • ginkgolinter: from 0.23.0 to 0.23.1
    • gocheckcompilerdirectives: from 1.3.0 to 1.4.0
    • gocritic: from 0.14.3 to 0.14.4
    • gomoddirectives: add missing IgnoreForbidden field
    • iface: from 1.4.2 to 1.4.3
    • mirror: from 1.3.0 to 1.3.3
    • nilnil: from 1.1.1 to 1.1.2
    • protogetter: from 0.3.20 to 0.3.21

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux
red-hat-konflux Bot requested a review from a team as a code owner August 23, 2026 02:03
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow buf-pull-request / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedAug 24, 2026, 1:28 AM

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
main 47.37% <ø> (-0.02%) ⬇️
v1beta2 61.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@larrymou9

Copy link
Copy Markdown
Contributor

Performance Tests passed

PR #1445
Branch konflux/mintmaker/main/golangci-golangci-lint-2.x
SHA 840754cc661e3bbc4a5be5a3e8302dd4a0d3646f
Build #48
Image(s) tested inventory-api:on-pr-840754cc661e3bbc4a5be5a3e8302dd4a0d3646f

Tests run: InsightsKesselK6_runnerAPI

📊 Performance Results

InsightsKesselK6_runnerAPI

Metric Result Value Min Max
SUMMARY.total_rps ✅ PASS 2403.945 1784.878 2584.645
SUMMARY.fail_ratio ✅ PASS 0.000 0.000 0.000
SUMMARY.avg_response_time ✅ PASS 110.302 102.566 148.602
SUMMARY.median_response_time ✅ PASS 5.261 4.812 9.754
SUMMARY.95percentile ✅ PASS 834.238 763.577 944.467
SUMMARY.num_requests ✅ PASS 937543.000 696105.000 1008013.000
SUMMARY.num_failures ✅ PASS 0.000 0.000 0.000

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/golangci-golangci-lint-2.x branch from 840754c to 16f608c Compare August 24, 2026 01:28
@red-hat-konflux red-hat-konflux Bot changed the title Update dependency golangci/golangci-lint to v2.13.0 Update dependency golangci/golangci-lint to v2.13.1 Aug 24, 2026
@larrymou9

Copy link
Copy Markdown
Contributor

Performance Tests failed

PR #1445
Branch konflux/mintmaker/main/golangci-golangci-lint-2.x
SHA 16f608cf4fb84b31e31d4f75f873bdabf7ad5da8
Build #50
Image(s) tested inventory-api:on-pr-16f608cf4fb84b31e31d4f75f873bdabf7ad5da8

Tests run: InsightsKesselK6_runnerAPI

📊 Performance Results

InsightsKesselK6_runnerAPI

Metric Result Value Min Max
SUMMARY.total_rps ❌ FAIL 1762.158 1784.878 2584.645
SUMMARY.fail_ratio ✅ PASS 0.000 0.000 0.000
SUMMARY.avg_response_time ❌ FAIL 150.537 102.566 148.602
SUMMARY.median_response_time ❌ FAIL 9.838 4.812 9.754
SUMMARY.95percentile ✅ PASS 897.749 763.577 944.467
SUMMARY.num_requests ❌ FAIL 687244.000 696105.000 1008013.000
SUMMARY.num_failures ✅ PASS 0.000 0.000 0.000

@ambient-code

ambient-code Bot commented Aug 24, 2026

Copy link
Copy Markdown

Automated Dependency Review — PR #1445

Decision: Do not merge as-is — lint failure requires a fix

Risk: Low (once the formatting issue is addressed)

Observations

  • golangci-lint v2.12.2 → v2.13.1: Minor+patch bump of a dev-only static analysis tool — zero runtime impact. Single-line diff in .github/workflows/golangci-lint.yml.
  • Lint CI check is failing: The updated linter now catches a pre-existing goimports formatting violation in internal/service/resources/kesselinventoryservice_test.go:226:1 that the old version (v2.12.2) did not flag. This is not a regression — it's a stricter check in the new linter version.
  • Fix is trivial: Run goimports -w internal/service/resources/kesselinventoryservice_test.go either as a commit on this PR or as a separate fix to main before rebasing. The underlying update is safe.
  • Upstream changes: v2.13.0 adds go1.27 support, a cache fix, and updates ~20 bundled linters. exhaustruct is deprecated in favor of exhaustruct_v5. v2.13.1 patches 4 linter bugs (ginkgolinter, gofmt, staticcheck, wsl_v5).
  • All other CI checks pass: Build, E2E, smoke, CodeQL, Snyk all green. Only the lint check and the pre-existing Anchore-Grype scan (Go stdlib CVEs requiring Go 1.26.6) are failing.

⚠️ Disclaimer: This review was generated by an automated AI process. These are soft recommendations — please use your own judgment and accountability when deciding to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants