Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GPU GitHub runner to avoid version confusion #795

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jan 2, 2025

Issue link

What changes have been made

Renaming GPU GitHub runner.
This is leftover change missed in #787.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from Maxusmusti and Ygnas January 2, 2025 12:44
@sutaakar sutaakar requested review from Bobbins228 and removed request for Maxusmusti January 2, 2025 12:44
@sutaakar sutaakar added the test-guided-notebooks Run PR check to verify Guided notebooks label Jan 2, 2025
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch thanks Karel!
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (1225d38) to head (2f0c35d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          23       23           
  Lines        1345     1345           
=======================================
  Hits         1215     1215           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bobbins228 Bobbins228 removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jan 2, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2025
@Bobbins228
Copy link
Contributor

Hang on guided nbs are not running

@sutaakar
Copy link
Contributor Author

sutaakar commented Jan 2, 2025

the label trigger is messy, will remove and add label again

@sutaakar sutaakar added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Jan 2, 2025
@Bobbins228 Bobbins228 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@sutaakar sutaakar added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Jan 2, 2025
@Bobbins228
Copy link
Contributor

@sutaakar Can you re-push to this branch?

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 2, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ChristianZaccaria
Copy link
Collaborator

the label trigger is messy, will remove and add label again

@sutaakar fix is on the way, thanks Karel.

Fix: #796

Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, ChristianZaccaria, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Bobbins228,ChristianZaccaria]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 28ef138 into project-codeflare:main Jan 2, 2025
15 checks passed
@sutaakar sutaakar deleted the github-runner branch January 2, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-guided-notebooks Run PR check to verify Guided notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants