Update CLI with the new SelectedTests using Pydantic #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-amjr
requested review from
ccruzagralopes,
gladystonfranca,
hiltonlima,
mikaelhm and
rquidute
ccruzagralopes
approved these changes
Nov 10, 2023
…operation was replaced for the missing 'config' option
mikaelhm
approved these changes
Nov 10, 2023
rquidute
approved these changes
Nov 10, 2023
hiltonlima
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the CLI code to support the new "SelectedTests" parameter.
This change is related to the Backend PR#16 that replace the old chain of dictionaries with Pydantic objects.
Also, some async client closure call were modified to guarantee that those are closed, even when an error occurs, using "finally" from the "try-except" operations.
Finally, the socket messages received to update the tests being run had no ID as expected (e.g. "test_suite_execution_id"). The message was carrying only the index of the correspondent Suite, Case or Step. The code was adapted for those index (e.g. "test_suite_execution_index").
Socket Message for Suite Update:
type=<MessageTypeEnum.TEST_UPDATE: 'test_update'> payload=TestUpdate(test_type='Test Suite', body=TestSuiteUpdate(state=<TestStateEnum.EXECUTING: 'executing'>, errors=[], failures=None, test_suite_execution_index=0))Developper Testing Files
Test Run:
test_run_2023-11-09-17:22:12.log
Test config json file example:
tests.json