fix(e2ee): scope persisted stores by account JID#428
Merged
Conversation
…ount data leakage Trust stores (verified peers, pinned fingerprints, key-change alerts, plaintext overrides, cert rejections), the verification sync version, the E2EE toggle, and the ignore list all used global localStorage keys. On a multi-account setup this let one account inherit another's trust decisions — a security issue for E2EE data. Each store now uses buildScopedStorageKey() to suffix the key with the bare JID, with one-shot migration from the old unscoped key and a rehydrate() action triggered on account switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary