fix(deps): apply zod-validation-error override to unbreak ESLint#427
Closed
mremond wants to merge 1 commit into
Closed
fix(deps): apply zod-validation-error override to unbreak ESLint#427mremond wants to merge 1 commit into
mremond wants to merge 1 commit into
Conversation
eslint-plugin-react-hooks@7.1.1 hard-imports `zod-validation-error/v4`, a subpath that only exists in zod-validation-error v4. The root package.json already pins `zod-validation-error: 4.0.2` via overrides (added during the React 19 migration, e3dfe4c), but the lockfile was never regenerated — so 3.5.4 stayed resolved, and 3.5.4 only exports `.`, making `npm run lint` crash with ERR_PACKAGE_PATH_NOT_EXPORTED in the @xmpp/fluux workspace. Pin only the zod-validation-error lockfile entry to 4.0.2 (its peer `zod: ^3.25.0 || ^4.0.0` is satisfied by the project's zod 3.25.76). No other dependency resolutions change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run lintcrashes in the@xmpp/fluuxworkspace with:Root cause:
eslint-plugin-react-hooks@7.1.1(pulled in by a recent dependency bump) hard-importszod-validation-error/v4— a subpath that only exists inzod-validation-errorv4. The plugin's declared range (^3.5.0 || ^4.0.0) is too permissive, so npm kept the already-resolved3.5.4, which exports only..The root
package.jsonalready pinszod-validation-error: 4.0.2viaoverrides(added during the React 19 migration in e3dfe4c), but the lockfile was never regenerated to honor it — so3.5.4stayed resolved and the import crashed.Fix: pin the single
zod-validation-errorlockfile entry to4.0.2. Its peer requirementzod: ^3.25.0 || ^4.0.0is satisfied by the project'szod@3.25.76, and4.0.2exposes the./v4subpath react-hooks needs. The change is deliberately scoped to that one entry — no other dependency resolutions move (avoids bundling incidental within-range bumps into this fix).