Fix for strands branching #8394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues identified in the last p5 discord call:
1. State modification in a deeply nested for loop doesn't work
This is because branches need to detect what variables are modified inside of them to correctly construct a control flow graph. They were intentionally not traversing into nested loops, since those have already parsed inside of them, but we still needed to grab the modification list from those nested loops and propagate them out.
2. You can't early return from branches
Previously we assumed a single final return value. I've added handling for early returns now.
Here's an updated version of the looping game of life shader with this build: https://editor.p5js.org/davepagurek/sketches/33ZrbAhDN