Fix WebGPU filters in CDN builds using duck typing for nodes (closes … #8349
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessing#8344) - Added isStrandsNode in node constructor - Replaced instanceof check with property check to handle duplicate modules in p5.js + p5.webgpu.js - Tested locally: filter(BLUR) now applies correctly in WEBGPU mode
davepagurek
approved these changes
Dec 19, 2025
Contributor
davepagurek
left a comment
davepagurek
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Contributor
|
@all-contributors please add @Piyushrathoree for code |
Contributor
|
I've put up a pull request to add @Piyushrathoree! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8344
This Resolves the issue of filter not working with WEBGPU with CDN.
Problem - the instanceof in StrandsNode is not working properly with p5.webgpu.js.
fix - introduced duck typing with isStrandsNode property.
Tested locally with built lib/p5.js + lib/p5.webgpu.js:
Changes:
before:
after:
getting something like this.
PR Checklist
npm run lintpasses